From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: Fix sleep-with-spinlock recovery regression
Date: Tue, 19 Aug 2008 17:59:11 -0700 [thread overview]
Message-ID: <20080820005910.GA27759@mail.oracle.com> (raw)
In-Reply-To: <20080820005115.GF8070@wotan.suse.de>
On Tue, Aug 19, 2008 at 05:51:15PM -0700, Mark Fasheh wrote:
> On Tue, Aug 19, 2008 at 05:22:15PM -0700, Mark Fasheh wrote:
> > This fixes a bug introduced with 539d8264093560b917ee3afe4c7f74e5da09d6a5:
> > [PATCH 2/2] ocfs2: Fix race between mount and recovery
>
> Ok, version 2 - with a bug fix.
>
> From: Mark Fasheh <mfasheh@suse.com>
>
> [PATCH] ocfs2: Fix sleep-with-spinlock recovery regression
>
> This fixes a bug introduced with 539d8264093560b917ee3afe4c7f74e5da09d6a5:
> [PATCH 2/2] ocfs2: Fix race between mount and recovery
>
> ocfs2_mark_dead_nodes() was reading journal inodes while holding the
> spinlock protecting our in-memory recovery state. The fix is very simple -
> the disk state is protected by a cluster lock that's already held, so we
> just move the spinlock down past the read.
>
> Signed-off-by: Mark Fasheh <mfasheh@suse.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>
--
"We'd better get back, `cause it'll be dark soon,
and they mostly come at night. Mostly."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
prev parent reply other threads:[~2008-08-20 0:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 0:22 [Ocfs2-devel] [PATCH] ocfs2: Fix sleep-with-spinlock recovery regression Mark Fasheh
2008-08-20 0:51 ` Mark Fasheh
2008-08-20 0:59 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820005910.GA27759@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.