All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	corentincj@iksaif.net, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: Awkward rfkill corner cases
Date: Wed, 20 Aug 2008 02:42:11 +0100	[thread overview]
Message-ID: <20080820014211.GA7592@srcf.ucam.org> (raw)
In-Reply-To: <20080820013214.GF29336@khazad-dum.debian.net>

On Tue, Aug 19, 2008 at 10:32:14PM -0300, Henrique de Moraes Holschuh wrote:

> Then, I have no futher comments.  Looks good to me.

Excellent, glad I've got that right.

One completely unrelated question. In the following situation (relevant 
to Dells, not the Eee)

* The system has a key (not a switch) that in firmware disables the 
hardware (HARD_BLOCKED)
* That key generates an event through the keyboard controller, but not 
through any other obviously detectable means
* The radio control is also controllable through software (SOFT_BLOCKED)

Should pressing the key generate a KEY_WLAN event?

I note that rfkill-input will, if the device is in HARD_BLOCKED state, 
attempt to set it to UNBLOCKED. This sounds like generating the keycode 
is the wrong thing to do, since it'll cause rfkill-input to try to undo 
the change that's just been made. However, if the key isn't mapped 
there's no obvious way for any of the stack to determine that a change 
has been made and propagate that to userspace. What should we be doing 
here?

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2008-08-20  1:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-04 17:08 [PATCH 1/2] eeepc-laptop: Fix user after free Matthew Garrett
2008-08-04 17:15 ` [PATCH 2/2] eeepc-laptop: Use standard interfaces Matthew Garrett
2008-08-04 17:53   ` Ivo van Doorn
2008-08-04 17:36     ` Matthew Garrett
2008-08-04 21:21       ` Henrique de Moraes Holschuh
2008-08-04 21:29   ` Henrique de Moraes Holschuh
2008-08-06  9:23 ` [PATCH v2 1/2] eeepc-laptop: Fix user after free Matthew Garrett
2008-08-06  9:25   ` [PATCH v2 2/2] eeepc-laptop: Use standard interfaces Matthew Garrett
2008-08-19  9:58     ` Andrew Morton
2008-08-19 11:13       ` Matthew Garrett
2008-08-19 23:09         ` Henrique de Moraes Holschuh
2008-08-19 23:24           ` Matthew Garrett
2008-08-20  1:18             ` Henrique de Moraes Holschuh
2008-08-20  1:28               ` Matthew Garrett
2008-08-20  1:32                 ` Henrique de Moraes Holschuh
2008-08-20  1:42                   ` Matthew Garrett [this message]
2008-08-20  2:30                     ` Awkward rfkill corner cases Henrique de Moraes Holschuh
2008-10-08 20:50         ` [PATCH v2 2/2] eeepc-laptop: Use standard interfaces Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080820014211.GA7592@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=akpm@linux-foundation.org \
    --cc=corentincj@iksaif.net \
    --cc=hmh@hmh.eng.br \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.