From: Dave Chinner <david@fromorbit.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs@oss.sgi.com, markgw@sgi.com
Subject: Re: TAKE 981498 - Use xfs_idestroy() to cleanup an inode.
Date: Wed, 20 Aug 2008 13:56:42 +1000 [thread overview]
Message-ID: <20080820035642.GB6061@disturbed> (raw)
In-Reply-To: <20080820033302.AF92058C52A8@chook.melbourne.sgi.com>
On Wed, Aug 20, 2008 at 01:33:02PM +1000, Lachlan McIlroy wrote:
> Use xfs_idestroy() to cleanup an inode.
I'm not sure what has been checked in this patch, even though it's
recorded that I reviewed it. Yes, I reviewed the original patch, but
I asked for changes to be made. I *haven't reviewed* what got
checked in.
With the changelog being entirely useless - not even mentioning it
fixes a memory leak or a deadlock - I have no idea what changes were
made in response to my initial review. I now have to wait for CVS
or git to be updated before being able to find out what just got
checked in so I can review it.
Lachlan (and for everyone else @ sgi), in future if someone in the
community reviews a patch and asks for change, can you please repost
the modified patches to close the review cycle before anything is
checked in?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-08-20 3:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 3:33 TAKE 981498 - Use xfs_idestroy() to cleanup an inode Lachlan McIlroy
2008-08-20 3:56 ` Dave Chinner [this message]
2008-08-20 6:13 ` Lachlan McIlroy
2008-08-20 11:15 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820035642.GB6061@disturbed \
--to=david@fromorbit.com \
--cc=lachlan@sgi.com \
--cc=markgw@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.