From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KVke0-0001V8-Nr for mharc-grub-devel@gnu.org; Wed, 20 Aug 2008 06:10:24 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KVkdz-0001Ur-8s for grub-devel@gnu.org; Wed, 20 Aug 2008 06:10:23 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KVkdx-0001Uf-HA for grub-devel@gnu.org; Wed, 20 Aug 2008 06:10:22 -0400 Received: from [199.232.76.173] (port=33710 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KVkdx-0001Uc-4l for grub-devel@gnu.org; Wed, 20 Aug 2008 06:10:21 -0400 Received: from aybabtu.com ([69.60.117.155]:40669) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KVkdu-00024m-Ne for grub-devel@gnu.org; Wed, 20 Aug 2008 06:10:19 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KVkV5-00072v-QB for grub-devel@gnu.org; Wed, 20 Aug 2008 12:01:12 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KVkcc-0003Ar-U5 for grub-devel@gnu.org; Wed, 20 Aug 2008 12:08:58 +0200 Date: Wed, 20 Aug 2008 12:08:58 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080820100858.GA8201@thorin> References: <20080817130119.GA22343@pina.cat> <877iaf20jx.fsf@xs4all.nl> <20080817142916.GB28198@pina.cat> <20080817153719.GC9696@thorin> <20080817191129.GA4789@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080817191129.GA4789@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Replace magic numbers by constants X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Aug 2008 10:10:23 -0000 On Sun, Aug 17, 2008 at 09:11:29PM +0200, Carles Pina i Estany wrote: > Ok: > > -------- > 2008-08-17 Carles Pina i Estany > > * menu/normal.c (run_menu): Replace hardcoded numbers with macros > (16 for GRUB_TERM_UP and 14 for GRUB_TERM_DOWN) > -------- Thanks, I checked this in. Btw, were you going to add support for PageUp / PageDown as well? :-) -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."