From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, michael_e_brown@dell.com
Subject: Re: [PATCH 2/2] Add Dell laptop driver
Date: Wed, 20 Aug 2008 11:21:25 +0100 [thread overview]
Message-ID: <20080820102125.GA14278@srcf.ucam.org> (raw)
In-Reply-To: <20080819234637.c6075e16.akpm@linux-foundation.org>
On Tue, Aug 19, 2008 at 11:46:37PM -0700, Andrew Morton wrote:
> > +struct calling_interface_buffer {
> > + u16 class;
> > + u16 select;
> > + volatile u32 input[4];
> > + volatile u32 output[4];
> > +} __attribute__ ((packed));
>
> checkpatch will direct you to a fine document.
The address of the structure is passed to the BIOS, and it's then
modified in system management mode. I think volatile is the right thing
here? I'll fix up the rest.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-08-20 10:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 20:24 [PATCH 0/2] Add Dell laptop driver Matthew Garrett
2008-08-16 20:26 ` [PATCH 1/2] Export SMI call functionality from dcdbas driver Matthew Garrett
2008-08-16 20:30 ` [PATCH 2/2] Add Dell laptop driver Matthew Garrett
2008-08-16 20:47 ` Arjan van de Ven
2008-08-16 20:51 ` Matthew Garrett
2008-08-20 6:46 ` Andrew Morton
2008-08-20 10:21 ` Matthew Garrett [this message]
2008-09-18 20:22 ` [PATCH 0/2] " Michael E Brown
-- strict thread matches above, loose matches on Subject: below --
2008-08-16 23:17 [PATCH 2/2] " Parag Warudkar
2008-08-16 23:23 ` Matthew Garrett
2008-08-16 23:31 ` Parag Warudkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820102125.GA14278@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael_e_brown@dell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.