From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KVlIO-0006pb-VL for mharc-grub-devel@gnu.org; Wed, 20 Aug 2008 06:52:09 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KVlIH-0006o6-Hx for grub-devel@gnu.org; Wed, 20 Aug 2008 06:52:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KVlID-0006mE-1w for grub-devel@gnu.org; Wed, 20 Aug 2008 06:51:59 -0400 Received: from [199.232.76.173] (port=45438 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KVlIA-0006ks-Cp for grub-devel@gnu.org; Wed, 20 Aug 2008 06:51:55 -0400 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:47824 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KVlI9-0005NU-T0 for grub-devel@gnu.org; Wed, 20 Aug 2008 06:51:54 -0400 Received: from pinux (86.81.221.87.dynamic.jazztel.es [87.221.81.86]) by mail.pina.cat (Postfix) with ESMTP id AF271288FBA35 for ; Wed, 20 Aug 2008 12:51:52 +0200 (CEST) Received: by pinux (Postfix, from userid 1000) id 7A8E35474; Wed, 20 Aug 2008 12:51:50 +0200 (CEST) Date: Wed, 20 Aug 2008 12:51:50 +0200 From: Carles Pina i Estany To: The development of GRUB 2 Message-ID: <20080820105150.GA8827@pina.cat> References: <20080817130119.GA22343@pina.cat> <877iaf20jx.fsf@xs4all.nl> <20080817142916.GB28198@pina.cat> <20080817153719.GC9696@thorin> <20080817191129.GA4789@pina.cat> <20080820100858.GA8201@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080820100858.GA8201@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Replace magic numbers by constants X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Aug 2008 10:52:03 -0000 Hi, On Aug/20/2008, Robert Millan wrote: > On Sun, Aug 17, 2008 at 09:11:29PM +0200, Carles Pina i Estany wrote: > > Ok: > > > > -------- > > 2008-08-17 Carles Pina i Estany > > > > * menu/normal.c (run_menu): Replace hardcoded numbers with macros > > (16 for GRUB_TERM_UP and 14 for GRUB_TERM_DOWN) > > -------- > > Thanks, I checked this in. > > Btw, were you going to add support for PageUp / PageDown as well? :-) Yes, that was my plan. Today (probably) I will write a proposal of how would behave (how much lines would scroll, which physical line number would be the new selected -last one of the screen, first one-). When we agree (if we do :-) ) I will write the patch (hopefully on weekend). I will also start a new mailing thread. -- Carles Pina i Estany GPG id: 0x17756391 http://pinux.info