All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jouni Hogander <jouni.hogander@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP: DISPC: Enable dispc wake up capability
Date: Wed, 20 Aug 2008 14:59:15 +0300	[thread overview]
Message-ID: <20080820115914.GH29374@atomide.com> (raw)
In-Reply-To: <1218792684-4202-1-git-send-email-jouni.hogander@nokia.com>

* Jouni Hogander <jouni.hogander@nokia.com> [080815 12:51]:
> Without wakeup enable omap doesn't wake up on dispc interrupts. This
> causes problems in a case where mpu is in sleep state and dispc
> interrupt fires.

Pushing today.

Tony

> Signed-off-by: Jouni Hogander <jouni.hogander@nokia.com>
> ---
>  drivers/video/omap/dispc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/omap/dispc.c b/drivers/video/omap/dispc.c
> index 3d64314..d232ea9 100644
> --- a/drivers/video/omap/dispc.c
> +++ b/drivers/video/omap/dispc.c
> @@ -1393,10 +1393,10 @@ static int omap_dispc_init(struct omapfb_device *fbdev, int ext_mode,
>  		enable_digit_clocks(0);
>  	}
>  
> -	/* Enable smart idle and autoidle */
> +	/* Enable smart standby/idle, autoidle and wakeup */
>  	l = dispc_read_reg(DISPC_SYSCONFIG);
>  	l &= ~((3 << 12) | (3 << 3));
> -	l |= (2 << 12) | (2 << 3) | (1 << 0);
> +	l |= (2 << 12) | (2 << 3) | (1 << 2) | (1 << 0);
>  	dispc_write_reg(DISPC_SYSCONFIG, l);
>  	omap_writel(1 << 0, DSS_BASE + DSS_SYSCONFIG);
>  
> -- 
> 1.5.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2008-08-20 13:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15  9:31 [PATCH] OMAP: DISPC: Enable dispc wake up capability Jouni Hogander
2008-08-20 11:59 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080820115914.GH29374@atomide.com \
    --to=tony@atomide.com \
    --cc=jouni.hogander@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.