All of lore.kernel.org
 help / color / mirror / Atom feed
From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/test t-covercmd.sh
Date: 20 Aug 2008 13:34:34 -0000	[thread overview]
Message-ID: <20080820133434.29420.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac at sourceware.org	2008-08-20 13:34:33

Modified files:
	test           : t-covercmd.sh 

Log message:
	fail testcase for failed commands inside the for loop

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-covercmd.sh.diff?cvsroot=lvm2&r1=1.2&r2=1.3

--- LVM2/test/t-covercmd.sh	2008/08/13 14:28:17	1.2
+++ LVM2/test/t-covercmd.sh	2008/08/20 13:34:33	1.3
@@ -54,35 +54,36 @@
    lvcreate -n "$lv" -l 1%FREE -i5 -I256 "$vg"'
 
 test_expect_success "test *scan and *display tools" \
-  'pvscan &&
-   vgscan &&
-   lvscan &&
-   for i in b k m g t p e H B K M G T P E ; do pvdisplay --units $i ; done &&
+  'pvscan              &&
+   vgscan              &&
+   lvscan              &&
+   lvmdiskscan         &&
    vgdisplay --units k &&
-   lvdisplay --units g'
+   lvdisplay --units g &&
+   for i in b k m g t p e H B K M G T P E ; do \
+     pvdisplay --units "$i" "$d1" || return $? ; done'
 
 test_expect_success "test vgexport vgimport tools" \
-  'vgchange -an "$vg" &&
-   vgexport "$vg" &&
-   vgimport "$vg" &&
+  'vgchange -an "$vg"  &&
+   vgexport "$vg"      &&
+   vgimport "$vg"      &&
    vgchange -ay "$vg"'
 
 # "-persistent y --major 254 --minor 20"
+# "-persistent n"
 test_expect_success "test various lvm utils" \
-  'lvmdiskscan &&
-   for i in dumpconfig formats segtypes ; do lvm $i ; done &&
-   for i in pr \"p rw\" an ay -refresh  "-monitor y" "-monitor n" \
-      "-persistent n" -resync \
-      "-addtag MYTAG" "-deltag MYTAG"; \
-      do lvchange -$i "$vg"/"$lv" ; done &&
-   pvck "$d1" &&
-   vgck "$vg" &&
-   lvrename "$vg" "$lv" "$lv-rename" &&
-   vgcfgbackup -f $(pwd)/backup.$$ "$vg"  &&
-   vgchange -an "$vg" &&
-   pvdisplay &&
-   vgcfgrestore  -f $(pwd)/backup.$$ "$vg" &&
-   vgremove -f "$vg" &&
+  'for i in dumpconfig formats segtypes 
+     do lvm "$i" || return $? ; done                 &&
+   for i in pr "p rw" an ay "-monitor y" "-monitor n" \
+     -resync -refresh "-addtag MYTAG" "-deltag MYETAG"
+     do lvchange -$i "$vg"/"$lv" || return $? ; done &&
+   pvck "$d1"                                        &&
+   vgck "$vg"                                        &&
+   lvrename "$vg" "$lv" "$lv-rename"                 &&
+   vgcfgbackup -f "$(pwd)/backup.$$" "$vg"           &&
+   vgchange -an "$vg"                                &&
+   vgcfgrestore  -f "$(pwd)/backup.$$" "$vg"         &&
+   vgremove -f "$vg"                                 &&
    pvresize --setphysicalvolumesize 10M "$d1"'
 
 test_expect_failure "test various errors and obsoleted tools" \



             reply	other threads:[~2008-08-20 13:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20 13:34 zkabelac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-06-28 21:49 LVM2/test t-covercmd.sh wysochanski
2008-08-13 14:28 zkabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080820133434.29420.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.