From: Alex Riesen <raa.lkml@gmail.com>
To: Jim Meyering <meyering@redhat.com>
Cc: git list <git@vger.kernel.org>
Subject: Re: [PATCH] * remote.c (valid_fetch_refspec): remove useless if-before-free test
Date: Wed, 20 Aug 2008 21:40:02 +0200 [thread overview]
Message-ID: <20080820194002.GC16626@blimp.local> (raw)
In-Reply-To: <87k5ecx2pl.fsf@rho.meyering.net>
Jim Meyering, Tue, Aug 19, 2008 20:46:30 +0200:
> We removed a handful of these useless if-before-free tests
> several months ago. This change removes a new one that snuck back in.
Something used to crash in free when passed NULL. It's one of the
reasons why some cross-platform projects have xfree which does the
check (sometimes depending on platform). Admittedly, it is a long time
since I saw such a platform (some old SunOS it was, I believe).
next prev parent reply other threads:[~2008-08-20 19:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 18:46 [PATCH] * remote.c (valid_fetch_refspec): remove useless if-before-free test Jim Meyering
2008-08-20 19:40 ` Alex Riesen [this message]
2008-08-20 20:22 ` Jim Meyering
2008-08-20 23:38 ` Brandon Casey
2008-08-21 0:16 ` Junio C Hamano
2008-08-21 0:33 ` Brandon Casey
2008-08-21 2:42 ` Junio C Hamano
2008-08-22 0:16 ` [PATCH] remote.c: add a function for deleting a refspec array and use it (twice) Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820194002.GC16626@blimp.local \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=meyering@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.