From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Optimize PLB4 Arbiter and Memory Queue settings for PPC 440SP/SPe, PPC405EX and PPC 460EX/GT
Date: Thu, 21 Aug 2008 10:52:54 +0200 [thread overview]
Message-ID: <200808211052.54704.sr@denx.de> (raw)
In-Reply-To: <1219250331.9479.14.camel@svdcld02>
On Wednesday 20 August 2008, Prodyut Hazarika wrote:
> Resending the patch since it was not copied to Stefan. Stefan, please
> ignore the previous post.
>
> Read pipeline depth set to 4 for PPC440SP/SPE, PPC405EX, PPC460EX/GT/SX
> processors Moved PLB4 Arbiter register definitions to ppc4xx.h since it is
> shared across processors Optimize Memory Queue settings for PPC440SP/SPE
> and PPC460EX/GT/SX processors Add register bit definitions for Memory Queue
> Configuration registers
Applied to u-boot-ppc4xx. Thanks.
Still a few comments though (for the next time):
- Please don't add too long lines to the commit text. Since tools like
git-log will indent the commit text, please restrict this text to
something like 70 chars per line.
- The line "Resending the patch..." above needs to go below the "---"
line. This way it will not appear in the commit text after applying.
- Don't indent the commit text.
- You still introduced a few too long lines in the code (I already
commented about this). I'll clean this up with a follow up patch.
- Your patch introduces trailing white spaces. I fixed this. Please
take extra care next time. I suggest running checkpatch.pl or
applying the patch to your local repo via git-am. This will give
you some warnings/errors.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2008-08-21 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 16:38 [U-Boot] [PATCH] ppc4xx: Optimize PLB4 Arbiter and Memory Queue settings for PPC 440SP/SPe, PPC405EX and PPC 460EX/GT Prodyut Hazarika
2008-08-21 8:52 ` Stefan Roese [this message]
2008-08-21 14:49 ` Prodyut Hazarika
2008-08-21 14:58 ` Stefan Roese
-- strict thread matches above, loose matches on Subject: below --
2008-08-20 16:33 [U-Boot] [PATCH] ppc4xx: Optimize PLB4 arbiter and memory queue " Prodyut Hazarika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808211052.54704.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.