From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KWA15-00061D-CD
	for mharc-grub-devel@gnu.org; Thu, 21 Aug 2008 09:15:55 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KWA13-00060F-8B
	for grub-devel@gnu.org; Thu, 21 Aug 2008 09:15:53 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KWA10-0005ye-0L
	for grub-devel@gnu.org; Thu, 21 Aug 2008 09:15:52 -0400
Received: from [199.232.76.173] (port=54099 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KWA0y-0005yQ-Oi
	for grub-devel@gnu.org; Thu, 21 Aug 2008 09:15:48 -0400
Received: from aybabtu.com ([69.60.117.155]:49756)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1KWA0y-0003hx-HB
	for grub-devel@gnu.org; Thu, 21 Aug 2008 09:15:48 -0400
Received: from [192.168.10.10] (helo=thorin)
	by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69) (envelope-from <rmh@aybabtu.com>) id 1KW9s2-0004Xi-Ai
	for grub-devel@gnu.org; Thu, 21 Aug 2008 15:06:34 +0200
Received: from rmh by thorin with local (Exim 4.63)
	(envelope-from <rmh@aybabtu.com>) id 1KW9za-00045Y-Cv
	for grub-devel@gnu.org; Thu, 21 Aug 2008 15:14:22 +0200
Date: Thu, 21 Aug 2008 15:14:22 +0200
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Message-ID: <20080821131422.GA15592@thorin>
References: <1219266086.4903.37.camel@fz.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1219266086.4903.37.camel@fz.local>
Organization: free as in freedom
X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird!
	www.mozilla.com/thunderbird
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.13 (2006-08-11)
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] fix for a memleak in grub_ntfs_mount
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Aug 2008 13:15:53 -0000

On Wed, Aug 20, 2008 at 11:01:26PM +0200, Felix Zielcke wrote:
> 2008-08-20  Felix Zielcke  <fzielcke@z-51.de>
> 
> 	* fs/ntfs.c (grub_ntfs_mount): Fix a memory leak. 
> 
> Index: fs/ntfs.c
> ===================================================================
> --- fs/ntfs.c	(Revision 1822)
> +++ fs/ntfs.c	(Arbeitskopie)
> @@ -850,6 +850,7 @@ fail:
>      {
>        free_file (&data->mmft);
>        free_file (&data->cmft);
> +      grub_free (data);
>      }
>    return 0;
>  }

Looks fine to me.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."