From: "Shawn O. Pearce" <spearce@spearce.org>
To: "H.Merijn Brand" <h.m.brand@xs4all.nl>
Cc: Mike Ralphson <mike@abacus.co.uk>,
git@vger.kernel.org, Mike Ralphson <mike.ralphson@gmail.com>,
Marek Zawirski <marek.zawirski@gmail.com>
Subject: Re: [JGIT PATCH] Typo in implementation of pack protocol
Date: Thu, 21 Aug 2008 08:02:14 -0700 [thread overview]
Message-ID: <20080821150214.GQ3483@spearce.org> (raw)
In-Reply-To: <20080821170042.457e62f1@pc09.procura.nl>
"H.Merijn Brand" <h.m.brand@xs4all.nl> wrote:
> On Thu, 21 Aug 2008 07:50:12 -0700, "Shawn O. Pearce"
> <spearce@spearce.org> wrote:
>
> > Mike Ralphson <mike@abacus.co.uk> wrote:
> > > cgit's receive-pack.c has never had the corresponding typo.
> > > Fix up method and member names to match.
> >
> > Whoops. Thanks.
> >
> > > - if (line.equals("capabilties^{}")) {
> > > + if (line.equals("capabilities^{}")) {
> > > // special line from git-receive-pack to show
> > > // capabilities when there are no refs to advertise
>
> Wouldn't it be nice to stick to ANSI Comments?
> I bet AIX xlc will fall over very very fast here
AIX xlc compiles Java code?
This is JGIT, written in Java, not git.git, written in ANSI C...
--
Shawn.
prev parent reply other threads:[~2008-08-21 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 10:36 [JGIT PATCH] Typo in implementation of pack protocol Mike Ralphson
2008-08-21 14:50 ` Shawn O. Pearce
2008-08-21 15:00 ` H.Merijn Brand
2008-08-21 15:02 ` H.Merijn Brand
2008-08-21 15:02 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080821150214.GQ3483@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=h.m.brand@xs4all.nl \
--cc=marek.zawirski@gmail.com \
--cc=mike.ralphson@gmail.com \
--cc=mike@abacus.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.