All of lore.kernel.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: paulus@samba.org, peter.oberparleiter@de.ibm.com,
	mm-commits@vger.kernel.org
Subject: - gcov-add-gcov-profiling-infrastructure-add-datagcov-to-data-section.patch removed from -mm tree
Date: Thu, 21 Aug 2008 09:20:11 -0700	[thread overview]
Message-ID: <200808211620.m7LGKBpp013777@imap1.linux-foundation.org> (raw)


The patch titled
     gcov: add .data.gcov to data section
has been removed from the -mm tree.  Its filename was
     gcov-add-gcov-profiling-infrastructure-add-datagcov-to-data-section.patch

This patch was dropped because an updated version will be merged

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: gcov: add .data.gcov to data section
From: Paul Mackerras <paulus@samba.org>

Andrew Morton writes:

> ia64 blew up in a perhaps similar fashion.  See lkml thread
> "ia64 allmodconfig on current mainline".
>
> The compiler is from http://userweb.kernel.org/~akpm/cross-compilers/
> (installable on redhatty systems, maybe others).

This is the problem:

Ld versions before about 2.18 or so (older than April 2007, I think)
have a bug where they put things in the wrong order in the output file
if you don't have all the sections listed in the vmlinux.lds with an
AT() clause on each one (it seems they all have to have AT(), or
none).  With the gcov stuff turned on, we get a .data.gcov section
which isn't mentioned in include/asm-generic/vmlinux.lds.h, which
triggers this bug.  This works around the ld bug by making sure
.data.gcov is mentioned in DATA_DATA.

The patch below should work around the problem, and may help ia64 as
well if it's the same problem there.  If it does fix it for you, you
can push it to Linus, since it touches a generic file.  Here's a SOB
in case you decide to do that (the previous paragraph should serve as
a patch description).  If you don't want to push this, I can do an
equivalent fix in arch/powerpc/kernel/vmlinux.lds.S.

Signed-off-by: Paul Mackerras <paulus@samba.org>
Cc: Peter Oberparleiter <peter.oberparleiter@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 include/asm-generic/vmlinux.lds.h |    1 +
 1 file changed, 1 insertion(+)

diff -puN include/asm-generic/vmlinux.lds.h~gcov-add-gcov-profiling-infrastructure-add-datagcov-to-data-section include/asm-generic/vmlinux.lds.h
--- a/include/asm-generic/vmlinux.lds.h~gcov-add-gcov-profiling-infrastructure-add-datagcov-to-data-section
+++ a/include/asm-generic/vmlinux.lds.h
@@ -43,6 +43,7 @@
 	*(.data)							\
 	*(.data.init.refok)						\
 	*(.ref.data)							\
+	*(.data.gcov)							\
 	DEV_KEEP(init.data)						\
 	DEV_KEEP(exit.data)						\
 	CPU_KEEP(init.data)						\
_

Patches currently in -mm which might be from paulus@samba.org are

linux-next.patch
git-powerpc.patch
x86-rename-iommu_num_pages-function-to-iommu_nr_pages.patch
powerpc-rename-iommu_num_pages-function-to-iommu_nr_pages.patch
introduce-generic-iommu_num_pages-function.patch
powerpc-use-iommu_num_pages-function-in-iommu-code.patch
gcov-add-gcov-profiling-infrastructure-add-datagcov-to-data-section.patch
gcov-architecture-specific-compile-flag-adjustments-powerpc-moved-stuff.patch
powerpc-hugetlb-pgtable-cache-access-cleanup.patch


                 reply	other threads:[~2008-08-21 16:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808211620.m7LGKBpp013777@imap1.linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=peter.oberparleiter@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.