From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH 0/2] MMC discard support (was [PATCH 0/7] Discard requests, v2) Date: Fri, 22 Aug 2008 13:20:11 +0200 Message-ID: <20080822112010.GJ20055@kernel.dk> References: <1218299181.26926.88.camel@pmac.infradead.org> <20080816190858.4d150ea1@mjolnir.drzeus.cx> <20080822092448.GC20055@kernel.dk> <20080822131314.23ba745a@mjolnir.drzeus.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, David Woodhouse To: Pierre Ossman Return-path: Received: from [93.163.65.50] ([93.163.65.50]:24127 "EHLO kernel.dk" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751727AbYHVLUN (ORCPT ); Fri, 22 Aug 2008 07:20:13 -0400 Content-Disposition: inline In-Reply-To: <20080822131314.23ba745a@mjolnir.drzeus.cx> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Aug 22 2008, Pierre Ossman wrote: > On Fri, 22 Aug 2008 11:24:48 +0200 > Jens Axboe wrote: > > > > > I agree with that, the thought did cross my mind earlier as well. I > > committed something like the below (in two patches). Do you want me to > > queue up your mmc patches as well? > > > > As it stands, no. If nobody can find a measurable improvement then this > code is just more things that can go wrong. It could just be that the device you tested with doesn't do anything with the discard information. But I agree, until there's a verified benefit to adding the code, we can leave it be. -- Jens Axboe