From: Robert Richter <robert.richter@amd.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Jan Beulich <jbeulich@novell.com>
Subject: Re: [PATCH] x86: fix: do not run code in amd_bus.c on non-AMD CPUs
Date: Fri, 22 Aug 2008 20:51:34 +0200 [thread overview]
Message-ID: <20080822185134.GA14103@erda.amd.com> (raw)
In-Reply-To: <86802c440808221147h4fb3c26cw31970678a100e2fc@mail.gmail.com>
On 22.08.08 11:47:45, Yinghai Lu wrote:
> 1. early_fill_mp_bus_info has checking with vendor/deviceid in itself.
Right, but scanning the pci bus could be skipped for non-AMD cpus. If
you don't like this check for your function I will resubmit a new
patch.
> 2. you didn't address: when cpu is hot plug in later,
> enable_pci_to_ecs_per_cpu will not be called.
> ( maxcpus and addtional_cpus)
Next patch?
-Robert
--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@amd.com
next prev parent reply other threads:[~2008-08-22 18:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 12:59 patch "x86: MOVE PCI IO ECS code to x86/pci" breaks CPU hotplug Jan Beulich
2008-08-21 13:29 ` Robert Richter
2008-08-21 16:25 ` Yinghai Lu
2008-08-21 16:46 ` Robert Richter
2008-08-22 18:23 ` [PATCH] x86: fix: do not run code in amd_bus.c on non-AMD CPUs Robert Richter
2008-08-22 18:47 ` Yinghai Lu
2008-08-22 18:51 ` Robert Richter [this message]
2008-08-22 18:57 ` Yinghai Lu
2008-08-22 19:13 ` Robert Richter
2008-08-22 18:23 ` [PATCH] x86: fix: make PCI ECS for AMD CPUs hotplug capable Robert Richter
2008-08-22 18:56 ` Yinghai Lu
2008-08-22 19:07 ` Robert Richter
2008-08-22 19:10 ` Yinghai Lu
2008-08-22 19:20 ` Robert Richter
2008-08-23 15:37 ` Ingo Molnar
2008-08-23 15:39 ` Ingo Molnar
2008-08-25 9:00 ` [PATCH] x86: fix: make PCI ECS for AMD CPUs hotplug capable (-v2) Robert Richter
2008-08-25 9:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080822185134.GA14103@erda.amd.com \
--to=robert.richter@amd.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.