From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Pavel Machek <pavel@suse.cz>, Ingo Molnar <mingo@elte.hu>,
Steven Rostedt <rostedt@goodmis.org>,
Nigel Cunningham <nigel@nigel.suspend2.net>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: ftraced and suspend to ram
Date: Fri, 22 Aug 2008 22:54:19 +0200 [thread overview]
Message-ID: <20080822205415.GA5452@joi> (raw)
In-Reply-To: <200808221839.35640.rjw@sisk.pl>
On Fri, Aug 22, 2008 at 06:39:34PM +0200, Rafael J. Wysocki wrote:
> On Friday, 22 of August 2008, Marcin Slusarz wrote:
> > On Fri, Aug 22, 2008 at 09:23:43AM +0200, Pavel Machek wrote:
> > > >
> > > > * Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > > >
> > > > > > > The code in question is the ftraced() function in
> > > > > > > kernel/trace/ftrace.c
> > > > > >
> > > > > > Thanks, I'll have a look in a while.
> > > > >
> > > > > Can you try the appended patch, please?
> > > >
> > > > makes sense - i've applied it to tip/tracing/urgent, see the tidied up
> > > > commit below.
> > > >
> > > > It should be no big issue not being able to trace across suspend+resume
> > > > - and that restriction will go away with Steve's build-time based mcount
> > > > patching mechanism in v2.6.28.
> > >
> > > Patch looks okay to me, but I'm not sure if another issue is not
> > > hiding under it. Did anyone actually test ftrace + suspend after
> > > applying this?
> >
> > I just tested this patch - it didn't help ;(
> >
> > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> > index 49f4c3f..02e41b2 100644
> > --- a/kernel/trace/ftrace.c
> > +++ b/kernel/trace/ftrace.c
> > @@ -27,6 +27,7 @@
> > #include <linux/ctype.h>
> > #include <linux/hash.h>
> > #include <linux/list.h>
> > +#include <linux/freezer.h>
> >
> > #include <asm/ftrace.h>
>
> This is needed to fix compilation, sorry for the omission.
>
> Still, did you test ftrace + suspend with the original patch and your fix
> applied and if you did, then what happend?
Suspend works fine. When I hit power button I see some informations from
video card (nvidia), then screen goes black and monitor says "no signal"
and then I see the same informations from video card, then BIOS and GRUB.
When everything works fine, X comes back after first infos from video card.
Marcin
next prev parent reply other threads:[~2008-08-22 20:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 15:49 ftraced and suspend to ram Steven Rostedt
2008-08-21 18:15 ` Rafael J. Wysocki
2008-08-21 18:26 ` Steven Rostedt
2008-08-21 18:37 ` Rafael J. Wysocki
2008-08-21 19:59 ` Rafael J. Wysocki
2008-08-22 4:46 ` Ingo Molnar
2008-08-22 7:23 ` Pavel Machek
2008-08-22 10:35 ` Marcin Slusarz
2008-08-22 10:46 ` Pavel Machek
2008-08-22 20:33 ` Steven Rostedt
2008-08-22 20:52 ` Rafael J. Wysocki
2008-08-22 20:55 ` Steven Rostedt
2008-08-22 21:11 ` Rafael J. Wysocki
2008-08-27 13:14 ` [PATCH] ftrace: disable tracing for " Steven Rostedt
2008-08-27 13:26 ` Rafael J. Wysocki
2008-08-28 12:39 ` [PATCH] ftrace: disable tracing for hibernation Rafael J. Wysocki
2008-08-28 12:42 ` Ingo Molnar
2008-08-28 12:44 ` Steven Rostedt
2008-08-29 23:53 ` Pavel Machek
2008-08-27 21:27 ` [PATCH] ftrace: disable tracing for suspend to ram Marcin Slusarz
2008-08-28 7:28 ` Pavel Machek
2008-08-29 13:43 ` Steven Rostedt
2008-08-22 16:39 ` ftraced and " Rafael J. Wysocki
2008-08-22 20:54 ` Marcin Slusarz [this message]
2008-08-22 21:17 ` Rafael J. Wysocki
2008-08-23 4:18 ` Russ Dill
2008-08-22 10:22 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080822205415.GA5452@joi \
--to=marcin.slusarz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nigel@nigel.suspend2.net \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.