All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: Josh Boyer <jwboyer@gmail.com>
Cc: Tirumala R Marri <tmarri@amcc.com>,
	fkan@amcc.com, linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] AMCC PPC460GT/EX PCI-E de-emphasis adjustment fix
Date: Fri, 22 Aug 2008 21:44:15 +0200	[thread overview]
Message-ID: <200808222144.15235.sr@denx.de> (raw)
In-Reply-To: <20080822133020.GE22283@yoda.jdub.homelinux.org>

On Friday 22 August 2008, Josh Boyer wrote:
> On Thu, Aug 21, 2008 at 09:53:34PM -0700, fkan@amcc.com wrote:
> >From: Tirumala R Marri <tmarri@amcc.com>
> >
> >During recent tests with PCI-E , it has been found the
> >DRV + De-Emphasis values are not optimum. These new values
> >are tested thouroughly.
> >
> >Signed-off-by: Tirumala R Marri <tmarri@amcc.com>
>
> If you are sending out a patch for someone, you need to include your
> Signed-off-by as well.  Just reply to this with it, no need to resend
> the just for this.
>
> Stefan, this looks good to me.  Or at least as far as I can tell from
> the somewhat magic values :)  Any comments?

Looks good for me too, so:

Acked-by: Stefan Roese <sr@denx.de>

Best regards,
Stefan

  parent reply	other threads:[~2008-08-22 19:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-22  4:53 [PATCH] AMCC PPC460GT/EX PCI-E de-emphasis adjustment fix fkan
2008-08-22 13:30 ` Josh Boyer
2008-08-22 15:33   ` Feng Kan
2008-08-22 19:44   ` Stefan Roese [this message]
2008-08-26  7:41     ` AMCC PPC460EX Canyonlands Hardwired interrupt Henry Bausley
2008-08-26  8:00       ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808222144.15235.sr@denx.de \
    --to=sr@denx.de \
    --cc=fkan@amcc.com \
    --cc=jwboyer@gmail.com \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=tmarri@amcc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.