All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carles Pina i Estany <carles@pina.cat>
To: grub-devel@gnu.org
Subject: GRUB_CONSOLE_KEY_NPAGE/PPAGE codes
Date: Sat, 23 Aug 2008 12:16:42 +0200	[thread overview]
Message-ID: <20080823101642.GA21564@pina.cat> (raw)


Hello,

I started to play with GRUB_TERM_PPAGE/NPAGE in normal/menu.c and I've
had a problem: they was working in opposite way than I've expected.

Tracing the problem deeper than swapping GRUB_TERM_PPAGE constant by
GRUB_TERM_NPAGE, I have found that this values comes from
GRUB_CONSOLE_KEY_NPAGE.

Let's define: NPAGE (next page) = PGDN (PG DOWN). PPAGE (previous page)
= PGUP (PG UP).  Is this assumption correct?

There is quite much places in Grub2 code that defines:
#define GRUB_CONSOLE_KEY_NPAGE          0x4900
#define GRUB_CONSOLE_KEY_PPAGE          0x5100

Googling for these codes, I've found that they are usually defined in
opposite way:
#define 	KEY_PGUP   0x4900
#define 	KEY_PGDN   0x5100

All other codes matches.

If this is correct, a bit later I will prepare a patch to swap 0x4900
and 0x5100 where it's needed.

Am I missing something?

Thanks,

-- 
Carles Pina i Estany		GPG id: 0x17756391
	http://pinux.info



             reply	other threads:[~2008-08-23 10:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-23 10:16 Carles Pina i Estany [this message]
2008-08-23 10:34 ` GRUB_CONSOLE_KEY_NPAGE/PPAGE codes Vesa Jääskeläinen
2008-08-23 13:03   ` Carles Pina i Estany
2008-08-24 12:33   ` Carles Pina i Estany
2008-08-24 16:08     ` Vesa Jääskeläinen
2008-08-30 11:25       ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080823101642.GA21564@pina.cat \
    --to=carles@pina.cat \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.