All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Pawel MOLL <pawel.moll@st.com>
Cc: linux-kernel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] genirq: irq_chip->startup() usage in setup_irq and set_irq_chained handler
Date: Sat, 23 Aug 2008 18:08:59 +0200	[thread overview]
Message-ID: <20080823160859.GE27974@elte.hu> (raw)
In-Reply-To: <1219416584.31630.639.camel@bri1004.bri.st.com>


* Pawel MOLL <pawel.moll@st.com> wrote:

> Hi, Ingo,
> 
> Apparently I have swapped To: and Cc: field in the original mail,
> apologies.
> 
> > This patch clarifies a usage of irq_chip->startup() callback:
> > 
> > 1. The "if (startup) startup(); else enabled();" code in setup_irq()
> >    is unnecessary, as startup() falls back to enabled() via
> >    default callbacks, set by irq_chip_set_defaults().
> > 
> > 2. When using set_irq_chained_handler() the startup() was never called,
> >    which is not good at all... Fixed. And again - when startup() is not
> >    defined the call will fall back to enable() than to unmask() via
> >    default callbacks.
> 
> Any comment on the patch?

looks good to me at first glance - but i Cc:-ed Thomas and Ben, maybe 
they have further comments.

	Ingo

  reply	other threads:[~2008-08-23 16:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 10:14 [PATCH] genirq: irq_chip->startup() usage in setup_irq and set_irq_chained handler Pawel MOLL
2008-08-22 14:49 ` Pawel MOLL
2008-08-23 16:08   ` Ingo Molnar [this message]
2008-08-23 22:43     ` Benjamin Herrenschmidt
2008-08-26 10:14       ` Pawel MOLL
2008-08-27  0:06         ` Benjamin Herrenschmidt
2008-09-01  8:47           ` Pawel MOLL
     [not found]           ` <1220260331.3299.1118.camel@bri1004.bri.st.com>
2008-09-06 18:37             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080823160859.GE27974@elte.hu \
    --to=mingo@elte.hu \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pawel.moll@st.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.