All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP2: Fix SPI driver failure on 2420 when running multi-omap config
Date: Sat, 23 Aug 2008 16:17:57 -0700	[thread overview]
Message-ID: <20080823231756.GJ4713@atomide.com> (raw)
In-Reply-To: <1219306810-12232-2-git-send-email-jarkko.nikula@nokia.com>

* Jarkko Nikula <jarkko.nikula@nokia.com> [080821 01:21]:
> SPI driver will do unhandled fault on OMAP2420 if trying to probe
> non-existing SPI busses. Register those additional busses runtime only
> for cpus having them.

Pushing today.

Tony

> Signed-off-by: Jarkko Nikula <jarkko.nikula@nokia.com>
> ---
>  arch/arm/mach-omap2/devices.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
> index cc5c294..bd49a0f 100644
> --- a/arch/arm/mach-omap2/devices.c
> +++ b/arch/arm/mach-omap2/devices.c
> @@ -255,10 +255,12 @@ static void omap_init_mcspi(void)
>  	platform_device_register(&omap2_mcspi1);
>  	platform_device_register(&omap2_mcspi2);
>  #if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP3)
> -	platform_device_register(&omap2_mcspi3);
> +	if (cpu_is_omap2430() || cpu_is_omap343x())
> +		platform_device_register(&omap2_mcspi3);
>  #endif
>  #ifdef CONFIG_ARCH_OMAP3
> -	platform_device_register(&omap2_mcspi4);
> +	if (cpu_is_omap343x())
> +		platform_device_register(&omap2_mcspi4);
>  #endif
>  }
>  
> -- 
> 1.5.6.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2008-08-23 23:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21  8:20 Fixes for multi-omap configurion Jarkko Nikula
2008-08-21  8:20 ` [PATCH] ARM: OMAP2: Fix SPI driver failure on 2420 when running multi-omap config Jarkko Nikula
2008-08-23 23:17   ` Tony Lindgren [this message]
2008-08-21  8:20 ` [PATCH] ARM: OMAP: Fix omap_wdt " Jarkko Nikula
2008-08-21  9:32   ` Jarkko Nikula
2008-08-23 23:18     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080823231756.GJ4713@atomide.com \
    --to=tony@atomide.com \
    --cc=jarkko.nikula@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.