From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KXGbW-0003m1-Ee for mharc-grub-devel@gnu.org; Sun, 24 Aug 2008 10:30:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXGbT-0003l1-S6 for grub-devel@gnu.org; Sun, 24 Aug 2008 10:30:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXGbQ-0003kV-42 for grub-devel@gnu.org; Sun, 24 Aug 2008 10:30:03 -0400 Received: from [199.232.76.173] (port=34880 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXGbP-0003kR-TE for grub-devel@gnu.org; Sun, 24 Aug 2008 10:29:59 -0400 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:54641 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXGbP-00061W-Dc for grub-devel@gnu.org; Sun, 24 Aug 2008 10:29:59 -0400 Received: from pinux (unknown [77.210.117.142]) by mail.pina.cat (Postfix) with ESMTP id 379E928906543 for ; Sun, 24 Aug 2008 16:29:58 +0200 (CEST) Received: by pinux (Postfix, from userid 1000) id 260D0167EE; Sun, 24 Aug 2008 16:29:44 +0200 (CEST) Date: Sun, 24 Aug 2008 16:29:44 +0200 From: Carles Pina i Estany To: grub-devel@gnu.org Message-ID: <20080824142944.GA9470@pina.cat> References: <20080824130216.GA5808@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080824130216.GA5808@pina.cat> User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Aug 2008 14:30:04 -0000 Hi, I was just thinking now... On Aug/24/2008, Carles Pina i Estany wrote: > * include/grub/powerpc/ieee1275/console.h (GRUB_TERM_NPAGE): > Changed to 0x5100. > (GRUB_TERM_PPAGE): Changed to 0x4900. > > * include/grub/sparc64/ieee1275/console.h: Likewise. > > * include/grub/i386/pc/console.h: Likewise. > > * include/grub/efi/console.h: Likewise. I was just thinking... is there any reason that we have the same macros in 4 different files? Why not having just a grub/console_scancodes.h: #ifndef GRUB_CONSOLE_SCAN_CODES #define GRUB_CONSOLE_KEY_LEFT 0x4B00 #define GRUB_CONSOLE_KEY_RIGHT 0x4D00 #define GRUB_CONSOLE_KEY_UP 0x4800 #define GRUB_CONSOLE_KEY_DOWN 0x5000 #define GRUB_CONSOLE_KEY_IC 0x5200 #define GRUB_CONSOLE_KEY_DC 0x5300 #define GRUB_CONSOLE_KEY_BACKSPACE 0x0008 #define GRUB_CONSOLE_KEY_HOME 0x4700 #define GRUB_CONSOLE_KEY_END 0x4F00 #define GRUB_CONSOLE_KEY_NPAGE 0x5100 #define GRUB_CONSOLE_KEY_PPAGE 0x4900 #endif and include this file from the other 4 files? Thanks, -- Carles Pina i Estany GPG id: 0x17756391 http://pinux.info