From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KXGsT-0003NV-RT
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 10:47:37 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KXGsS-0003Lq-N2
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 10:47:37 -0400
Received: from [199.232.76.173] (port=45087 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KXGsS-0003Lh-Ik
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 10:47:36 -0400
Received: from mail2.shareable.org ([80.68.89.115]:38704)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <jamie@shareable.org>) id 1KXGsS-0001Ow-5k
	for qemu-devel@nongnu.org; Sun, 24 Aug 2008 10:47:36 -0400
Date: Sun, 24 Aug 2008 15:47:33 +0100
From: Jamie Lokier <jamie@shareable.org>
Subject: Re: [Qemu-devel] [PATCH] Fix vfork() syscall emulation
Message-ID: <20080824144733.GB28033@shareable.org>
References: <1219450705-1376-1-git-send-email-kirill@shutemov.name>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1219450705-1376-1-git-send-email-kirill@shutemov.name>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>, Paul Brook <paul@codesourcery.com>

Kirill A. Shutemov wrote:
> -    if (flags & CLONE_VM) {
> +    if (!(flags & CLONE_VFORK) && flags & CLONE_VM) {

Parentheses around (flags & CLONE_VM) would be good here.

-- Jamie