From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KXKPu-0006C0-Vo for mharc-grub-devel@gnu.org; Sun, 24 Aug 2008 14:34:23 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXKPs-0006A3-L3 for grub-devel@gnu.org; Sun, 24 Aug 2008 14:34:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXKPr-00069b-7h for grub-devel@gnu.org; Sun, 24 Aug 2008 14:34:20 -0400 Received: from [199.232.76.173] (port=38519 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXKPr-00069O-4C for grub-devel@gnu.org; Sun, 24 Aug 2008 14:34:19 -0400 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:52721 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXKPq-00082L-Q8 for grub-devel@gnu.org; Sun, 24 Aug 2008 14:34:19 -0400 Received: from pinux (unknown [77.210.88.177]) by mail.pina.cat (Postfix) with ESMTP id 5A16528906543 for ; Sun, 24 Aug 2008 20:34:17 +0200 (CEST) Received: by pinux (Postfix, from userid 1000) id B9569117E7; Sun, 24 Aug 2008 20:34:10 +0200 (CEST) Date: Sun, 24 Aug 2008 20:34:10 +0200 From: Carles Pina i Estany To: grub-devel@gnu.org Message-ID: <20080824183410.GA5773@pina.cat> References: <20080824130216.GA5808@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080824130216.GA5808@pina.cat> User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE (summary) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Aug 2008 18:34:21 -0000 Hello, On Aug/24/2008, Carles Pina i Estany wrote: > ChangeLog: > -------- > 2008-08-24 Carles Pina i Estany > > * include/grub/powerpc/ieee1275/console.h (GRUB_TERM_NPAGE): > Changed to 0x5100. > (GRUB_TERM_PPAGE): Changed to 0x4900. > > * include/grub/sparc64/ieee1275/console.h: Likewise. > > * include/grub/i386/pc/console.h: Likewise. > > * include/grub/efi/console.h: Likewise. > -------- > > (this new values are the same used in Grub and also the same that one > can find googling for PGUP and PGDN key codes). > > If everything is correct, could someone please commit it? summarizing all discussions about this topic (there is three different issues): a) This patch fix the incorrect values of GRUB_TERM_PPAGE/NPAGE. In my opinion, can be committed (so, feel free to commit if you think so). b) The name of PPAGE/NPAGE/IC/... are ncurses based and not very intuitive. Discussing if we should change these names in the same thread. c) If it's save merging all places where these macros appears (including a new file with the values). Discussing in the same thread. I would go patching or not patching these issues one by one or we will discuss it forever :-) -- Carles Pina i Estany GPG id: 0x17756391 http://pinux.info