From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: let 64 bit to use 32 bit calibrate_apic_clock
Date: Mon, 25 Aug 2008 09:47:04 +0200 [thread overview]
Message-ID: <20080825074704.GA20698@elte.hu> (raw)
In-Reply-To: <1219642886-22030-1-git-send-email-yhlu.kernel@gmail.com>
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> Signed-of-by: Yinghai Lu <yhlu.kernel@gmail.com>
applied to tip/irq/sparseirq - thanks Yinghai.
btw., why was this bit needed:
> @@ -659,6 +575,7 @@ static int __init calibrate_APIC_clock(v
> delta = lapic_cal_t1 - lapic_cal_t2;
> apic_printk(APIC_VERBOSE, "... lapic delta = %ld\n", delta);
>
> +#ifdef CONFIG_X86_PM_TIMER
> /* Check, if the PM timer is available */
> deltapm = lapic_cal_pm2 - lapic_cal_pm1;
> apic_printk(APIC_VERBOSE, "... PM timer delta = %ld\n", deltapm);
> @@ -687,6 +604,7 @@ static int __init calibrate_APIC_clock(v
> }
> pm_referenced = 1;
> }
> +#endif
wouldnt this be a (small) fix for the pre-unification 32-bit side as
well, which we should put into tip/x86/urgent as well?
Ingo
next prev parent reply other threads:[~2008-08-25 7:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 5:41 [PATCH] x86: let 64 bit to use 32 bit calibrate_apic_clock Yinghai Lu
2008-08-25 7:47 ` Ingo Molnar [this message]
2008-08-25 8:04 ` Yinghai Lu
2008-08-25 16:47 ` Cyrill Gorcunov
2008-08-25 20:05 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080825074704.GA20698@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.