Re: [Qemu-devel] [PATCH 4/6] Use libuuid if available.

[Gleb Natapov <gleb@qumranet.com>]

On Sun, Aug 24, 2008 at 08:50:42PM +0300, Blue Swirl wrote:
> On 8/24/08, Gleb Natapov <gleb@qumranet.com> wrote:
> >  +# uuid library
> >  +if test "$uuid" = "yes" ; then
> >  +  `pkg-config uuid 2> /dev/null` || uuid="no"
> >  +fi
> 
> Please implement the probe like ncurses one.
> 
> >  +static int uuid_dont_generate;
> 
> Positive logic would be clearer: generate_uuid = 1;
> 
> >  +#ifdef CONFIG_UUID
> >  +                uuid_dont_generate = 1;
> 
> generate_uuid = 0;
> 
> >  +    if (!uuid_dont_generate)
> >  +        uuid_generate(qemu_uuid);
> 
> if (generate_uuid)
> 
Done.

--
			Gleb.