From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KXaG5-0008DM-0Q
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 07:29:17 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KXaG1-0008Be-Ia
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 07:29:16 -0400
Received: from [199.232.76.173] (port=44911 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KXaG1-0008BZ-AY
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 07:29:13 -0400
Received: from relay01.mx.bawue.net ([193.7.176.67]:37032)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <ths@networkno.de>) id 1KXaG0-00081P-HY
	for qemu-devel@nongnu.org; Mon, 25 Aug 2008 07:29:13 -0400
Date: Mon, 25 Aug 2008 13:28:41 +0200
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] [PATCH] MIPS: Fix dmtc0 instruction
Message-ID: <20080825112841.GB994@networkno.de>
References: <48B03DFA.6080404@reactos.org>
	<20080823172404.GK32516@volta.aurel32.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20080823172404.GK32516@volta.aurel32.net>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org

Aurelien Jarno wrote:
> On Sat, Aug 23, 2008 at 06:42:34PM +0200, Herv=E9 Poussineau wrote:
> > Hi,
> >=20
> > In gen_dmtc0 function, TCG temporary variable t0 is freed at the end of
> > the function. Variable is freed again in the gen_dmtc0 caller.
> > I removed the free in gen_dmtc0, to do like in gen_dmfc0, gen_mfc0,
> > gen_mtc0.
> >=20
> > Incidentally, this unregresses NetBSD on Pica 61.
> =20
> This was also affecting Linux MIPS64 and I have noticed the problem this
> morning (though it seems to be a few weeks old).

My old 64-bit testcase worked for some reason despite that bug. The current
debian/testing kernel image for malta/5kc failed, though.

> I have applied the patch, and also removed another tcg_temp_free(t0)
> which has been left. Thanks!

I can confirm it works here as well, thank you. However, I still see
QEMU hang with the debian kernel at IDE detection:

[...]
[    2.040127] pcnet32.c:v1.34-NAPI 14.Aug.2007 tsbogend@alpha.franken.de
[    2.040127] pcnet32: PCnet/PCI II 79C970A at 0x1020, 52:54:00:12:34:56 a=
ssigned IRQ 10.
[    2.040127] eth0: registered as PCnet/PCI II 79C970A
[    2.040127] pcnet32: 1 cards_found.
[    2.040127] Uniform Multi-Platform E-IDE driver
[    2.040127] ide: Assuming 33MHz system bus speed for PIO modes; override=
 with idebus=3Dxx
[    2.040127] PIIX4: IDE controller (0x8086:0x7111 rev 0x00) at  PCI slot =
0000:00:0a.1
[    2.040127] PCI: Enabling device 0000:00:0a.1 (0000 -> 0001)
[    2.040127] PIIX4: not 100% native mode: will probe irqs later
[    2.040127]     ide0: BM-DMA at 0x1040-0x1047, BIOS settings: hda:PIO, h=
db:PIO
[    2.040127]     ide1: BM-DMA at 0x1048-0x104f, BIOS settings: hdc:PIO, h=
dd:PIO

I figure CONFIG_NO_HZ has too high demands on the count/compare emulation.


Thiemo