From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXcni-0000ql-OT for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:12:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXcnh-0000qF-46 for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:12:10 -0400 Received: from [199.232.76.173] (port=49397 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXcnh-0000qC-0j for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:12:09 -0400 Received: from relay01.mx.bawue.net ([193.7.176.67]:57209) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KXcng-0006td-Ln for qemu-devel@nongnu.org; Mon, 25 Aug 2008 10:12:09 -0400 Date: Mon, 25 Aug 2008 16:12:03 +0200 From: Thiemo Seufer Subject: Re: [Qemu-devel] [PATCH] MIPS: Fix dmtc0 instruction Message-ID: <20080825141203.GC994@networkno.de> References: <48B03DFA.6080404@reactos.org> <20080823172404.GK32516@volta.aurel32.net> <20080825112841.GB994@networkno.de> <48B2ABDF.7070607@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <48B2ABDF.7070607@aurel32.net> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: qemu-devel@nongnu.org Aurelien Jarno wrote: > Thiemo Seufer a =E9crit : > > Aurelien Jarno wrote: > >> On Sat, Aug 23, 2008 at 06:42:34PM +0200, Herv=E9 Poussineau wrote: > >>> Hi, > >>> > >>> In gen_dmtc0 function, TCG temporary variable t0 is freed at the end = of > >>> the function. Variable is freed again in the gen_dmtc0 caller. > >>> I removed the free in gen_dmtc0, to do like in gen_dmfc0, gen_mfc0, > >>> gen_mtc0. > >>> > >>> Incidentally, this unregresses NetBSD on Pica 61. > >> =20 > >> This was also affecting Linux MIPS64 and I have noticed the problem th= is > >> morning (though it seems to be a few weeks old). > >=20 > > My old 64-bit testcase worked for some reason despite that bug. The cur= rent > > debian/testing kernel image for malta/5kc failed, though. > >=20 > >> I have applied the patch, and also removed another tcg_temp_free(t0) > >> which has been left. Thanks! > >=20 > > I can confirm it works here as well, thank you. However, I still see > > QEMU hang with the debian kernel at IDE detection: > >=20 > > [...] > > [ 2.040127] pcnet32.c:v1.34-NAPI 14.Aug.2007 tsbogend@alpha.franken.= de > > [ 2.040127] pcnet32: PCnet/PCI II 79C970A at 0x1020, 52:54:00:12:34:= 56 assigned IRQ 10. > > [ 2.040127] eth0: registered as PCnet/PCI II 79C970A > > [ 2.040127] pcnet32: 1 cards_found. > > [ 2.040127] Uniform Multi-Platform E-IDE driver > > [ 2.040127] ide: Assuming 33MHz system bus speed for PIO modes; over= ride with idebus=3Dxx > > [ 2.040127] PIIX4: IDE controller (0x8086:0x7111 rev 0x00) at PCI s= lot 0000:00:0a.1 > > [ 2.040127] PCI: Enabling device 0000:00:0a.1 (0000 -> 0001) > > [ 2.040127] PIIX4: not 100% native mode: will probe irqs later > > [ 2.040127] ide0: BM-DMA at 0x1040-0x1047, BIOS settings: hda:PI= O, hdb:PIO > > [ 2.040127] ide1: BM-DMA at 0x1048-0x104f, BIOS settings: hdc:PI= O, hdd:PIO > >=20 > > I figure CONFIG_NO_HZ has too high demands on the count/compare emulati= on. > >=20 >=20 > I don't have this problem. Are you sure it is related to CONFIG_NO_HZ? > AFAIK the problems with CONFIG_NO_HZ appear earlier, when computing the > CPU speed. I'M not sure, I only inferred it is a timing problem from the printk timing output. Thiemo