All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Dave Jones <davej@codemonkey.org.uk>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	cpufreq@vger.kernel.org, Alok Kataria <akataria@vmware.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [BUG] cpufreq: constant cpu_khz
Date: Mon, 25 Aug 2008 19:57:12 +0200	[thread overview]
Message-ID: <20080825175712.GA10848@elte.hu> (raw)
In-Reply-To: <20080825175547.GA26131@codemonkey.org.uk>


* Dave Jones <davej@codemonkey.org.uk> wrote:

>  > hm, that too is due to the tsc.c unification - Alok Cc:-ed. Applied 
>  > your fix to x86/urgent.
> 
> ACKed-by: Dave Jones <davej@redhat.com>
> 
> Good catch Peter.  I'm puzzled how that bug was latent on 64bit for so 
> long with no-one realising though.

i think it's the combination of these two factors:

 - bootup frequently is typically full-speed, so we calibrate things 
   right

 - cpufreq events are relatively slow-scale - and when they trigger the 
   system is definitely not under load. So how precisely the scheduler 
   functions isnt all that important in such scenarios - there's tons of
   CPU power available.

but it's indeed nice to have this fixed, and i just pushed the fix to 
Linus.

	Ingo

  reply	other threads:[~2008-08-25 17:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-25  6:33 [BUG] cpufreq: constant cpu_khz Peter Zijlstra
2008-08-25 11:35 ` Peter Zijlstra
2008-08-25 12:39   ` Ingo Molnar
2008-08-25 17:34     ` Alok Kataria
2008-08-25 17:55     ` Dave Jones
2008-08-25 17:57       ` Ingo Molnar [this message]
2008-08-25 18:22         ` Arjan van de Ven
2008-08-25 19:27           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080825175712.GA10848@elte.hu \
    --to=mingo@elte.hu \
    --cc=akataria@vmware.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=davej@codemonkey.org.uk \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.