From: Christoph Hellwig <hch@lst.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
Lachlan McIlroy <lachlan@sgi.com>,
Daniel J Blueman <daniel.blueman@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
xfs@oss.sgi.com, hch@lst.de
Subject: Re: [2.6.27-rc4] XFS i_lock vs i_iolock...
Date: Mon, 25 Aug 2008 23:55:32 +0200 [thread overview]
Message-ID: <20080825215532.GB28188@lst.de> (raw)
In-Reply-To: <1219647573.20732.28.camel@twins>
On Mon, Aug 25, 2008 at 08:59:33AM +0200, Peter Zijlstra wrote:
> How can you take two locks in one go? It seems to me you always need to
> take them one after another, and as soon as you do that, you have
> ordering constraints.
Yes, you would. Except that in all other places we only have a single
iolock involved, so the ordering of the second iolock and second ilock
don't matter.
Because of that I think declaring that xfs_lock_two_inodes can just
lock on lock type at a time might be the better solution.
next prev parent reply other threads:[~2008-08-25 21:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 21:12 [2.6.27-rc4] XFS i_lock vs i_iolock Daniel J Blueman
2008-08-25 1:02 ` Dave Chinner
2008-08-25 2:12 ` Lachlan McIlroy
2008-08-25 3:55 ` Dave Chinner
2008-08-25 6:59 ` Peter Zijlstra
2008-08-25 21:55 ` Christoph Hellwig [this message]
2008-08-26 2:45 ` Dave Chinner
2008-08-26 19:35 ` Christoph Hellwig
2008-08-29 1:20 ` Peter Leckie
2008-08-29 1:37 ` Dave Chinner
2008-08-26 20:13 ` Daniel J Blueman
2008-08-26 21:34 ` Daniel J Blueman
2008-08-26 1:55 ` Dave Chinner
2008-08-25 6:57 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080825215532.GB28188@lst.de \
--to=hch@lst.de \
--cc=daniel.blueman@gmail.com \
--cc=david@fromorbit.com \
--cc=lachlan@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.