From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Daniel P. Berrange" <berrange@redhat.com>
Subject: Re: [PATCH] mini-os: make xenbus_read_integer and
	xenbus_printf take const strings
Date: Tue, 26 Aug 2008 17:34:37 +0100
Message-ID: <20080826163437.GK19615@redhat.com>
References: <20080826161702.GB4555@implementation.uk.xensource.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20080826161702.GB4555@implementation.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Samuel Thibault <samuel.thibault@eu.citrix.com>, xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Tue, Aug 26, 2008 at 05:17:02PM +0100, Samuel Thibault wrote:
> mini-os: make xenbus_read_integer and xenbus_printf take const strings
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
> 
> diff -r c2472ded5c7c extras/mini-os/include/xenbus.h
> --- a/extras/mini-os/include/xenbus.h	Tue Aug 26 15:16:57 2008 +0100
> +++ b/extras/mini-os/include/xenbus.h	Tue Aug 26 17:06:09 2008 +0100
> @@ -83,12 +83,12 @@ char *xenbus_transaction_end(xenbus_tran
>  			     int *retry);
>  
>  /* Read path and parse it as an integer.  Returns -1 on error. */
> -int xenbus_read_integer(char *path);
> +int xenbus_read_integer(const char *path);
>  
>  /* Contraction of snprintf and xenbus_write(path/node). */
>  char* xenbus_printf(xenbus_transaction_t xbt,
> -                                  char* node, char* path,
> -                                  char* fmt, ...);
> +                                  const char* node, const char* path,
> +                                  const char* fmt, ...);

If you annotate that declaration with

   __attribute__ ((__format__ (printf, 4, 3)))

then gcc will warn you any time a caller gives incorrect args vs
format string, which can catch some otherwise hidden bugs.

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|