From: Christoph Hellwig <hch@infradead.org>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-scsi@vger.kernel.org, jens.axboe@oracle.com,
dougg@torque.net, michaelc@cs.wisc.edu,
James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH 1/5] block: add gfp_mask argument to blk_rq_map_user and blk_rq_map_user_iov
Date: Tue, 26 Aug 2008 12:35:45 -0400 [thread overview]
Message-ID: <20080826163545.GA26201@infradead.org> (raw)
In-Reply-To: <1219716654-27827-2-git-send-email-fujita.tomonori@lab.ntt.co.jp>
On Tue, Aug 26, 2008 at 11:10:50AM +0900, FUJITA Tomonori wrote:
> Currently, blk_rq_map_user and blk_rq_map_user_iov always do
> GFP_KERNEL allocation.
>
> This adds gfp_mask argument to blk_rq_map_user and blk_rq_map_user_iov
> so sg can use it (sg always does GFP_ATOMIC allocation).
Most GFP_ATOMIC looks rather spurious to me, and are there probably
for some historic reason. Do you have a caller that actually needs
GFP_ATOMIC because it's under a spinlock or from irq context, or is this
just to stay as close as possible to the existing sg code?
next prev parent reply other threads:[~2008-08-26 16:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 2:10 [PATCH 0/5] convert sg to use the block layer FUJITA Tomonori
2008-08-26 2:10 ` [PATCH 1/5] block: add gfp_mask argument to blk_rq_map_user and blk_rq_map_user_iov FUJITA Tomonori
2008-08-26 2:10 ` [PATCH 2/5] block: introduce struct rq_map_data to use reserved pages FUJITA Tomonori
2008-08-26 2:10 ` [PATCH 3/5] sg: convert the non-data path to use the block layer FUJITA Tomonori
2008-08-26 2:10 ` [PATCH 4/5] sg: convert the direct IO " FUJITA Tomonori
2008-08-26 2:10 ` [PATCH 5/5] sg: convert the indirect " FUJITA Tomonori
2008-08-26 16:35 ` Christoph Hellwig [this message]
2008-08-27 1:30 ` [PATCH 1/5] block: add gfp_mask argument to blk_rq_map_user and blk_rq_map_user_iov FUJITA Tomonori
2008-08-26 7:56 ` [PATCH 0/5] convert sg to use the block layer Jens Axboe
2008-08-27 2:14 ` FUJITA Tomonori
2008-08-27 7:10 ` Jens Axboe
2008-08-27 23:26 ` FUJITA Tomonori
2008-08-28 6:51 ` Jens Axboe
2008-08-28 7:07 ` Jens Axboe
2008-08-28 7:17 ` [PATCH 1/5] block: add gfp_mask argument to blk_rq_map_user and blk_rq_map_user_iov FUJITA Tomonori
2008-08-28 7:17 ` [PATCH 2/5] block: introduce struct rq_map_data to use reserved pages FUJITA Tomonori
2008-08-28 7:17 ` [PATCH 3/5] sg: convert the non-data path to use the block layer FUJITA Tomonori
2008-08-28 7:17 ` [PATCH 4/5] sg: convert the direct IO " FUJITA Tomonori
2008-08-28 7:17 ` [PATCH 5/5] sg: convert the indirect " FUJITA Tomonori
2008-08-28 7:34 ` [PATCH 1/5] block: add gfp_mask argument to blk_rq_map_user and blk_rq_map_user_iov Jens Axboe
2008-08-28 7:32 ` [PATCH 0/5] convert sg to use the block layer FUJITA Tomonori
2008-08-27 20:14 ` Douglas Gilbert
2008-08-27 23:26 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080826163545.GA26201@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dougg@torque.net \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.