From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [PATCH] mini-os: make xenbus_read_integer and
	xenbus_printf take const strings
Date: Tue, 26 Aug 2008 17:42:06 +0100
Message-ID: <20080826164206.GH4555@implementation.uk.xensource.com>
References: <20080826161702.GB4555@implementation.uk.xensource.com>
	<20080826163437.GK19615@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20080826163437.GK19615@redhat.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Daniel P. Berrange, le Tue 26 Aug 2008 17:34:37 +0100, a =E9crit :
> If you annotate that declaration with
>=20
>    __attribute__ ((__format__ (printf, 4, 3)))
>=20
> then gcc will warn you any time a caller gives incorrect args vs
> format string, which can catch some otherwise hidden bugs.

Indeed, actually all mini-os's *print* functions should have it, IIRC
there are a lot of fixes needed to have this compile with -Werror :)

Samuel