From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: [PATCH] mini-os: Add printf format checking to
	xenbus_printf
Date: Tue, 26 Aug 2008 17:47:43 +0100
Message-ID: <20080826164743.GI4555@implementation.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

mini-os: Add printf format checking to xenbus_printf

Reported-by: "Daniel P. Berrange" <berrange@redhat.com>
Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>

diff -r 43486a7f918c extras/mini-os/include/xenbus.h
--- a/extras/mini-os/include/xenbus.h	Tue Aug 26 16:38:23 2008 +0100
+++ b/extras/mini-os/include/xenbus.h	Tue Aug 26 17:44:01 2008 +0100
@@ -88,7 +88,8 @@ int xenbus_read_integer(const char *path
 /* Contraction of snprintf and xenbus_write(path/node). */
 char* xenbus_printf(xenbus_transaction_t xbt,
                                   const char* node, const char* path,
-                                  const char* fmt, ...);
+                                  const char* fmt, ...)
+                   __attribute__((__format__(printf, 4, 5)));
 
 /* Reset the XenBus system. */
 void fini_xenbus(void);