From: Christoph Hellwig <hch@lst.de>
To: Helge Deller <deller@gmx.de>
Cc: Kyle McMartin <kyle@mcmartin.ca>,
linux-parisc <linux-parisc@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] compat_sys_ptrace conversions for parisc
Date: Tue, 26 Aug 2008 22:03:11 +0200 [thread overview]
Message-ID: <20080826200311.GC3791@lst.de> (raw)
In-Reply-To: <48B2F0AF.3020005@gmx.de>
On Mon, Aug 25, 2008 at 07:49:35PM +0200, Helge Deller wrote:
> I agree that my comment suggests that splitting the patch into two parts
> could make sense to track the changes easier, but if you look into the
> original code you'll see, that I would need to duplicate all of the
> arch_ptrace code and then make the copied part 64bit-ready. Then the
> second patch would delete all of this again and replacing it with the
> generic function calls.
> IMHO that's a lot of coding and changes without any need. You'll first
> need to understand coding in my first patch which is then deleted
> afterwards with the second patch again. And if you look at the final
> ptrace.c file after applying my patch which I posted here, you'll see
> that arch_ptrace is now really small and simple to understand.
>
> That said, I'm not very motivated to split my patch.
Oh, parisc actually uses sys_ptrace as the 32bit entry point. Yes, I
see your point and take back the suggestion.
next prev parent reply other threads:[~2008-08-26 20:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-24 18:26 [PATCH] - Patch series for parisc Helge Deller
2008-08-24 18:33 ` [PATCH] compat_sys_ptrace conversions " Helge Deller
2008-08-25 16:52 ` Christoph Hellwig
2008-08-26 21:09 ` Roland McGrath
2008-08-25 17:11 ` Kyle McMartin
2008-08-25 17:49 ` Helge Deller
2008-08-26 20:03 ` Christoph Hellwig [this message]
2008-08-24 18:45 ` [PATCH] fix crash when trying to unwind user space Helge Deller
2008-08-24 18:51 ` [PATCH] drop superfluous .align 16 Helge Deller
2008-08-24 18:57 ` James Bottomley
2008-08-25 12:31 ` Helge Deller
2008-08-26 4:26 ` Grant Grundler
2008-08-26 12:42 ` Carlos O'Donell
2008-08-26 14:10 ` James Bottomley
2008-08-26 15:35 ` Carlos O'Donell
2008-08-24 19:04 ` [PATCH] ldcw inline assembler patch Helge Deller
2008-08-24 19:21 ` [PATCH] Change cpu_data[] and cpu_devices[] from array sized by NR_CPUS to per_cpu variables Helge Deller
2008-08-24 21:24 ` Helge Deller
2008-08-27 4:51 ` Grant Grundler
2008-08-27 20:42 ` Helge Deller
2008-08-24 19:49 ` [PATCH] - Patch series for parisc Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080826200311.GC3791@lst.de \
--to=hch@lst.de \
--cc=deller@gmx.de \
--cc=kyle@mcmartin.ca \
--cc=linux-parisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.