From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: jarkao2@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] pkt_sched: Fix dev_graft_qdisc() locking
Date: Wed, 27 Aug 2008 02:15:09 -0700 (PDT) [thread overview]
Message-ID: <20080827.021509.266949293.davem@davemloft.net> (raw)
In-Reply-To: <E1KXxy1-0000kI-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 26 Aug 2008 22:48:13 +1000
> Jarek Poplawski <jarkao2@gmail.com> wrote:
> > pkt_sched: Fix dev_graft_qdisc() locking
> >
> > During dev_graft_qdisc() dev is deactivated, so qdisc_root_lock()
> > returns wrong lock of noop_qdisc instead of qdisc_sleeping.
> >
> >
> > Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
>
> Looks good to me!
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks everyone.
prev parent reply other threads:[~2008-08-27 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 22:48 [PATCH] pkt_sched: Fix dev_graft_qdisc() locking Jarek Poplawski
2008-08-26 12:48 ` Herbert Xu
2008-08-26 13:05 ` Jarek Poplawski
2008-08-27 9:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080827.021509.266949293.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.