All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serue@us.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Pavel Emelyanov <xemul@openvz.org>,
	Robert Rex <robert.rex@exasol.com>,
	Roland McGrath <roland@redhat.com>,
	Sukadev Bhattiprolu <sukadev@us.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child_reaper change
Date: Tue, 26 Aug 2008 21:31:42 -0500	[thread overview]
Message-ID: <20080827023142.GB2320@us.ibm.com> (raw)
In-Reply-To: <20080824154912.GA3783@tv-sign.ru>

Quoting Oleg Nesterov (oleg@tv-sign.ru):
> de_thread() checks if the old leader was the ->child_reaper, this is not
> possible any longer. With the previous patch ->group_leader itself will
> change ->child_reaper on exit.

Neat.

> >From now find_new_reaper() is the only function (apart from initialization)
> which plays with ->child_reaper.
> 
> Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>

Acked-by: Serge Hallyn <serue@us.ibm.com>

> 
> --- 2.6.27-rc4/fs/exec.c~3_EXEC	2008-07-30 13:12:47.000000000 +0400
> +++ 2.6.27-rc4/fs/exec.c	2008-08-24 19:20:05.000000000 +0400
> @@ -825,8 +825,6 @@ static int de_thread(struct task_struct 
>  			schedule();
>  		}
> 
> -		if (unlikely(task_child_reaper(tsk) == leader))
> -			task_active_pid_ns(tsk)->child_reaper = tsk;
>  		/*
>  		 * The only record we have of the real-time age of a
>  		 * process, regardless of execs it's done, is start_time.

  reply	other threads:[~2008-08-27  2:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-24 15:49 [PATCH 3/4] pid_ns: de_thread: kill the now unneeded ->child_reaper change Oleg Nesterov
2008-08-27  2:31 ` Serge E. Hallyn [this message]
2008-08-27 11:38 ` Pavel Emelyanov
2008-08-27 18:04 ` sukadev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080827023142.GB2320@us.ibm.com \
    --to=serue@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=robert.rex@exasol.com \
    --cc=roland@redhat.com \
    --cc=sukadev@us.ibm.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.