Re: [PATCH] blkid: optimize dm_device_is_leaf() usage

[Karel Zak <kzak@redhat.com>]

On Wed, Aug 27, 2008 at 01:26:43AM -0600, Andreas Dilger wrote:
> On Aug 27, 2008  02:19 +0200, Karel Zak wrote:
> > On Tue, Aug 26, 2008 at 07:32:25PM -0400, Theodore Tso wrote:
> > > you'll just be re-inventing blkid.  If you don't cache, you'll either
> > 
> >  Hehe.. I will directly copy code from blkid and vol_id. It's open
> >  source. I needn't re-inventing ;-)
> 
> Couldn't you just change libblkid to export the probe functions?  It
> always makes me cringe when code like this is copied, because I just
> _know_ one or the other will become out of date, and it will take
> twice as much effort to keep them in sync.  I'd rather see people
> doing "high value" work instead of watching for and copying patches
> around.

 Yes, good point. Frankly, I think about it in last weeks. I have done
 work on the low-lever part of libfsprobe -- it shouldn't be a problem
 port this code to libblkid. The advantage will be a library that is
 usable for udev and backwardly compatible for the current blkid
 applications. I will try it...

    Karel

-- 
 Karel Zak  <kzak@redhat.com>