From: Gleb Natapov <gleb@qumranet.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Reset I32_APIC_BASE on system RESET
Date: Wed, 27 Aug 2008 16:44:48 +0300 [thread overview]
Message-ID: <20080827134448.GY6192@minantech.com> (raw)
Should be done according to spec.
Signed-off-by: Gleb Natapov <gleb@qumranet.com>
diff --git a/hw/apic.c b/hw/apic.c
index 43d748c..64e75ad 100644
--- a/hw/apic.c
+++ b/hw/apic.c
@@ -869,6 +869,10 @@ static int apic_load(QEMUFile *f, void *opaque, int version_id)
static void apic_reset(void *opaque)
{
APICState *s = opaque;
+
+ s->apicbase = 0xfee00000 |
+ (s->id ? 0 : MSR_IA32_APICBASE_BSP) | MSR_IA32_APICBASE_ENABLE;
+
apic_init_ipi(s);
if (s->id == 0) {
@@ -906,8 +910,6 @@ int apic_init(CPUState *env)
s->id = last_apic_id++;
env->cpuid_apic_id = s->id;
s->cpu_env = env;
- s->apicbase = 0xfee00000 |
- (s->id ? 0 : MSR_IA32_APICBASE_BSP) | MSR_IA32_APICBASE_ENABLE;
apic_reset(s);
--
Gleb.
next reply other threads:[~2008-08-27 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 13:44 Gleb Natapov [this message]
2008-09-02 0:10 ` [Qemu-devel] Reset I32_APIC_BASE on system RESET Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080827134448.GY6192@minantech.com \
--to=gleb@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.