All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: linux-usb@vger.kernel.org, Stefan Kopp <stefan_kopp@agilent.com>,
	Marcel Janssen <korgull@home.nl>,
	Felipe Balbi <me@felipebalbi.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: add USB test and measurement class driver
Date: Wed, 27 Aug 2008 08:28:48 -0700	[thread overview]
Message-ID: <20080827152848.GA19710@kroah.com> (raw)
In-Reply-To: <200808271056.37159.oliver@neukum.org>

On Wed, Aug 27, 2008 at 10:56:36AM +0200, Oliver Neukum wrote:
> Am Mittwoch 27 August 2008 02:05:01 schrieb Greg KH:
>  
> > I've now added this to my tree, and any review comments are greatly
> > welcome.
> 
> Unfortunately the issues are not trivial.

Nah, they are all easily fixable :)

> 1. USBTMC_SIZE_IOBUFFER
> use 2048. 4096 means a multipage allocation

So?  What difference does this really matter at normal USB speeds?

thanks,

greg k-h

  reply	other threads:[~2008-08-27 15:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27  0:05 [PATCH] USB: add USB test and measurement class driver Greg KH
2008-08-27  3:12 ` Greg KH
2008-08-27 16:36   ` Greg KH
2008-08-27  6:22 ` Marcel Janssen
2008-08-27 17:21   ` Greg KH
2008-08-27  8:08 ` Oliver Neukum
2008-08-27 15:40   ` Greg KH
2008-08-27 16:06   ` Alan Stern
2008-08-27 17:05     ` Oliver Neukum
2008-08-27  8:13 ` Oliver Neukum
2008-08-27 16:08   ` Greg KH
2008-08-27  8:56 ` Oliver Neukum
2008-08-27 15:28   ` Greg KH [this message]
2008-08-27 15:44     ` Oliver Neukum
2008-08-27 16:02       ` Greg KH
2008-08-27 16:11   ` Greg KH
2008-08-27 16:15   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080827152848.GA19710@kroah.com \
    --to=greg@kroah.com \
    --cc=korgull@home.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=me@felipebalbi.com \
    --cc=oliver@neukum.org \
    --cc=stefan_kopp@agilent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.