All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: [PATCH 2/2] sky2: display product info on boot.
Date: Wed, 27 Aug 2008 20:48:23 -0700	[thread overview]
Message-ID: <20080827204823.551eff56@extreme> (raw)
In-Reply-To: <20080827204626.4b65862f@extreme>

Change bootup messages to print more information. This is to help users
who may have old buggy EEPROM image.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
---
This can wait for 2.6.28

--- a/drivers/net/sky2.c	2008-08-27 19:21:52.000000000 -0700
+++ b/drivers/net/sky2.c	2008-08-27 19:21:56.000000000 -0700
@@ -4191,6 +4191,69 @@ static int __devinit pci_wake_enabled(st
 	return value & PCI_PM_CTRL_PME_ENABLE;
 }
 
+/*
+ * Read and parse the first part of Vital Product Data
+ */
+#define VPD_SIZE	128
+#define VPD_MAGIC	0x82
+
+static void __devinit sky2_vpd_info(struct sky2_hw *hw)
+{
+	int cap = pci_find_capability(hw->pdev, PCI_CAP_ID_VPD);
+	const u8 *p;
+	u8 *vpd_buf = NULL;
+	u16 len;
+	static struct vpd_tag {
+		char tag[2];
+		char *label;
+	} vpd_tags[] = {
+		{ "PN",	"Part Number" },
+		{ "EC", "Engineering Level" },
+		{ "MN", "Manufacturer" },
+	};
+
+	if (!cap)
+		goto out;
+
+	vpd_buf = kmalloc(VPD_SIZE, GFP_KERNEL);
+	if (!vpd_buf)
+		goto out;
+
+	if (sky2_vpd_read(hw, cap, vpd_buf, 0, VPD_SIZE))
+		goto out;
+
+	if (vpd_buf[0] != VPD_MAGIC)
+		goto out;
+	len = vpd_buf[1];
+	if (len == 0 || len > VPD_SIZE - 4)
+		goto out;
+	p = vpd_buf + 3;
+	dev_info(&hw->pdev->dev, "%.*s\n", len, p);
+	p += len;
+
+	while (p < vpd_buf + VPD_SIZE - 4) {
+		int i;
+
+		if (!memcmp("RW", p, 2))	/* end marker */
+			break;
+
+		len = p[2];
+		if (len > (p - vpd_buf) - 4)
+			break;
+
+		for (i = 0; i < ARRAY_SIZE(vpd_tags); i++) {
+			if (!memcmp(vpd_tags[i].tag, p, 2)) {
+				printk(KERN_DEBUG " %s: %.*s\n",
+				       vpd_tags[i].label, len, p + 3);
+				break;
+			}
+		}
+		p += len + 3;
+	}
+out:
+	kfree(vpd_buf);
+}
+
 /* This driver supports yukon2 chipset only */
 static const char *sky2_name(u8 chipid, char *buf, int sz)
 {
@@ -4289,13 +4352,13 @@ static int __devinit sky2_probe(struct p
 	if (err)
 		goto err_out_iounmap;
 
-	dev_info(&pdev->dev, "v%s addr 0x%llx irq %d Yukon-2 %s rev %d\n",
-		 DRV_VERSION, (unsigned long long)pci_resource_start(pdev, 0),
-		 pdev->irq, sky2_name(hw->chip_id, buf1, sizeof(buf1)),
-		 hw->chip_rev);
+	dev_info(&pdev->dev, "Yukon-2 %s chip revision %d\n",
+		 sky2_name(hw->chip_id, buf1, sizeof(buf1)), hw->chip_rev);
 
 	sky2_reset(hw);
 
+	sky2_vpd_info(hw);
+
 	dev = sky2_init_netdev(hw, 0, using_dac, wol_default);
 	if (!dev) {
 		err = -ENOMEM;
@@ -4546,6 +4609,8 @@ static struct pci_driver sky2_driver = {
 
 static int __init sky2_init_module(void)
 {
+	pr_info(PFX "driver version " DRV_VERSION "\n");
+
 	sky2_debug_init();
 	return pci_register_driver(&sky2_driver);
 }

  reply	other threads:[~2008-08-28  3:48 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28  3:46 [PATCH 1/2] sky2: EEPROM read/write bug fixes Stephen Hemminger
2008-08-28  3:48 ` Stephen Hemminger [this message]
2008-08-28 11:13 ` Ben Hutchings
2008-08-28 15:30   ` Stephen Hemminger
2008-08-30 15:03     ` Stephen Hemminger
2008-08-31 20:35       ` Ben Hutchings
2008-08-31 23:24         ` Stephen Hemminger
     [not found]   ` <20080903155316.1a0a5698@extreme>
2008-09-03 22:57     ` [PATCH 2/3] pci: revise VPD access interface Stephen Hemminger
2008-09-03 23:00       ` [PATCH 3/3] sky2: use pci_read_vpd to read info during boot Stephen Hemminger
2008-09-04  7:36         ` Jeff Garzik
2008-09-09  4:36           ` Jesse Barnes
2008-09-03 22:57   ` [PATCH 1/3] pci: VPD access timeout increase Stephen Hemminger
2008-09-04 12:52     ` Matthew Wilcox
2008-09-04 14:19       ` Ben Hutchings
2008-09-04 16:10         ` Matthew Wilcox
2008-09-04 16:32         ` Stephen Hemminger
2008-09-04 16:07     ` [PATCH] Return value from schedule() Matthew Wilcox
2008-09-04 16:14       ` Ingo Molnar
2008-09-04 16:21         ` Matthew Wilcox
2008-09-04 17:30           ` Arjan van de Ven
2008-09-04 17:48             ` Matthew Wilcox
2008-09-04 19:05               ` Stephen Hemminger
2008-09-05  7:40                 ` Peter Zijlstra
2008-09-03 14:25 ` [PATCH 1/2] sky2: EEPROM read/write bug fixes Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080827204823.551eff56@extreme \
    --to=shemminger@linux-foundation.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.