From: Jens Axboe <jens.axboe@oracle.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: kmalloc args reversed, small function definition fixes
Date: Thu, 28 Aug 2008 09:26:21 +0200 [thread overview]
Message-ID: <20080828072621.GQ20055@kernel.dk> (raw)
In-Reply-To: <1219868669.6069.53.camel@brick>
On Wed, Aug 27 2008, Harvey Harrison wrote:
> Noticed by sparse:
> block/blk-softirq.c:156:12: warning: symbol 'blk_softirq_init' was not declared. Should it be static?
> block/genhd.c:583:28: warning: function 'bdget_disk' with external linkage has definition
> block/genhd.c:659:17: warning: incorrect type in argument 1 (different base types)
> block/genhd.c:659:17: expected unsigned int [unsigned] [usertype] size
> block/genhd.c:659:17: got restricted gfp_t
> block/genhd.c:659:29: warning: incorrect type in argument 2 (different base types)
> block/genhd.c:659:29: expected restricted gfp_t [usertype] flags
> block/genhd.c:659:29: got unsigned int
> block: kmalloc args reversed
Woops, that kmalloc() is nasty. Thanks a lot, applied to for-2.6.28.
--
Jens Axboe
next prev parent reply other threads:[~2008-08-28 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 20:24 [PATCH] block: kmalloc args reversed, small function definition fixes Harvey Harrison
2008-08-28 7:26 ` Jens Axboe [this message]
2008-08-28 14:19 ` Christoph Hellwig
2008-08-28 14:28 ` Jens Axboe
2008-08-28 14:30 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828072621.GQ20055@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.