From: Jens Axboe <jens.axboe@oracle.com>
To: Andre Noll <maan@systemlinux.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>, jurriaan <thunder7@xs4all.nl>,
linux-kernel@vger.kernel.org, Neil Brown <neilb@suse.de>
Subject: Re: 2.6.27-rc4: lots of 'in_atomic():1, irqs_disabled():0' with software-raid1
Date: Thu, 28 Aug 2008 10:11:13 +0200 [thread overview]
Message-ID: <20080828081113.GW20055@kernel.dk> (raw)
In-Reply-To: <20080828075607.GA3795@skl-net.de>
On Thu, Aug 28 2008, Andre Noll wrote:
> On 09:48, Jens Axboe wrote:
> > Doh right, we of course can't block inside a RCU section. Then
> > bitmap.c:write_sb_page() wants fixing:
> >
> > rcu_read_lock();
> > rdev_for_each_rcu(...)
> > md_super_write(...)
> > bio_alloc(GFP_NOIO, 1);
>
> Also, md_super_write() does not check the return value of bio_alloc().
> That probably needs fixing as well.
No, that's the guarentee of mempool_alloc() - as long as you have
__GFP_WAIT set, you'll never see a NULL return.
--
Jens Axboe
next prev parent reply other threads:[~2008-08-28 8:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 17:05 2.6.27-rc4: lots of 'in_atomic():1, irqs_disabled():0' with software-raid1 jurriaan
2008-08-27 21:47 ` Rafael J. Wysocki
2008-08-28 7:33 ` Jens Axboe
2008-08-28 7:45 ` Andrew Morton
2008-08-28 7:48 ` Jens Axboe
2008-08-28 7:56 ` Andre Noll
2008-08-28 8:11 ` Jens Axboe [this message]
2008-08-28 8:04 ` Andre Noll
2008-08-28 8:27 ` Neil Brown
2008-08-28 8:36 ` Jens Axboe
2008-08-28 9:00 ` Andrew Morton
2008-08-29 7:36 ` Neil Brown
2008-08-29 7:47 ` Jens Axboe
2008-08-29 8:14 ` Andrew Morton
2008-08-29 5:44 ` Neil Brown
2008-08-29 5:48 ` Neil Brown
2008-08-29 7:11 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828081113.GW20055@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maan@systemlinux.org \
--cc=neilb@suse.de \
--cc=rjw@sisk.pl \
--cc=thunder7@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.