From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: [PATCH] PV-GRUB: fix example file [Was: PV Grub Questions] Date: Thu, 28 Aug 2008 16:27:37 +0100 Message-ID: <20080828152737.GY4523@implementation.uk.xensource.com> References: <1e16a9ed0808261257p763cb14uc6a3b28513cf94d2@mail.gmail.com> <20080828144305.GA11437@implementation.uk.xensource.com> <1e16a9ed0808280813o298372d8i54ed0946082d1945@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1e16a9ed0808280813o298372d8i54ed0946082d1945@mail.gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Todd Deshane Cc: xen-devel mailing list List-Id: xen-devel@lists.xenproject.org Todd Deshane, le Thu 28 Aug 2008 11:13:10 -0400, a =E9crit : > On Thu, Aug 28, 2008 at 10:43 AM, Samuel Thibault > wrote: > > Todd Deshane, le Tue 26 Aug 2008 15:57:50 -0400, a =E9crit : > >> extra =3D "(hd0,1)/boot/grub/menu.lst" > >> memory =3D 64 > >> vif =3D [ '' ] > >> disk =3D [ 'tap:aio:/root/benchvm/bin/img-xen-guest/image-0.img,hda,= w' ] > >> root =3D "/dev/hda2 ro" > > > > Oh, that root option is the cause of the menu not showing up. That > > shouldn't be here, since it's in menu.lst itself. >=20 > Cool, that is the first step on the way. I think that should be changed= in the > xmexample.pv-grub file, Gargl, I thought I had tested that file, but apparently not... Should be applied to the 3.3 tree too of course. Samuel pv-grub: fix example file Apparently 64MB is too short for the domain builder. No kernel option should be passed, as they are provided by menu.lst, and would only confuse grub. diff -r 51f868f2a29f tools/examples/xmexample.pv-grub --- a/tools/examples/xmexample.pv-grub Thu Aug 28 13:01:25 2008 +0100 +++ b/tools/examples/xmexample.pv-grub Thu Aug 28 16:23:26 2008 +0100 @@ -25,7 +25,7 @@ extra =3D "(hd0,0)/boot/grub/menu.lst" # WARNING: Creating a domain with insufficient memory may cause out of # memory errors. The domain needs enough memory to boot kernel # and modules. Allocating less than 32MBs is not recommended. -memory =3D 64 +memory =3D 128 =20 # A name for your domain. All domains must have different names. name =3D "ExampleDomain" @@ -119,32 +119,6 @@ disk =3D [ 'phy:hda1,hda1,w' ] #vtpm =3D [ 'instance=3D1,backend=3D0' ] =20 #-----------------------------------------------------------------------= ----- -# Set the kernel command line for the new domain. -# You only need to define the IP parameters and hostname if the domain's -# IP config doesn't, e.g. in ifcfg-eth0 or via DHCP. -# You can use 'extra' to set the runlevel and custom environment -# variables used by custom rc scripts (e.g. VMID=3D, usr=3D ). - -# Set if you want dhcp to allocate the IP address. -#dhcp=3D"dhcp" -# Set netmask. -#netmask=3D -# Set default gateway. -#gateway=3D -# Set the hostname. -#hostname=3D "vm%d" % vmid - -# Set root device. -root =3D "/dev/hda1 ro" - -# Root device for nfs. -#root =3D "/dev/nfs" -# The nfs server. -#nfs_server =3D '192.0.2.1' =20 -# Root directory on the nfs server. -#nfs_root =3D '/full/path/to/root/directory' - -#-----------------------------------------------------------------------= ----- # Configure the behaviour when a domain exits. There are three 'reasons= ' # for a domain to stop: poweroff, reboot, and crash. For each of these = you # may specify: