diff for duplicates of <20080828194336.GJ9193@ghostprotocols.net> diff --git a/a/1.txt b/N1/1.txt index e393d31..3ceb87d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -43,7 +43,7 @@ Why not use list_for_each_entry()? > + if (feat < entry->feat_num) > + break; -> + if (entry->feat_num = feat && entry->is_local = is_local) { +> + if (entry->feat_num == feat && entry->is_local == is_local) { > + dccp_feat_val_destructor(entry->feat_num, &entry->val); <first reaction> @@ -81,7 +81,7 @@ frees to NULL and then reusing it somehow cool, here you use list_for_each_entry :-) -> + if (entry->feat_num = feat_num && entry->is_local = is_local) +> + if (entry->feat_num == feat_num && entry->is_local == is_local) > + return entry; > + else if (entry->feat_num > feat_num) > + break; @@ -106,7 +106,7 @@ constructor, doing just the kmalloc + member init? > +{ > + struct dccp_feat_entry *new = dccp_feat_entry_new(fn_list, feat, local); > + -> + if (new = NULL) +> + if (new == NULL) > + return -ENOMEM; > + > + new->feat_num = feat; @@ -133,14 +133,14 @@ constructor, doing just the kmalloc + member init? > +{ > + struct dccp_feat_entry *new = dccp_feat_entry_new(fn_list, feat, local); > + -> + if (new = NULL) +> + if (new == NULL) > + return DCCP_RESET_CODE_TOO_BUSY; > + > + new->feat_num = feat; > + new->is_local = local; > + new->state = FEAT_STABLE; /* transition in 6.6.2 */ > + new->needs_confirm = 1; -> + new->empty_confirm = (fval = NULL); +> + new->empty_confirm = (fval == NULL); > + new->val.nn = 0; /* zeroes the whole structure */ > + if (!new->empty_confirm) > + new->val = *fval; diff --git a/a/content_digest b/N1/content_digest index 664ebb9..8c4d603 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,13 @@ + "ref\01219945512-7723-1-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-2-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-3-git-send-email-gerrit@erg.abdn.ac.uk\0" "ref\01219945512-7723-4-git-send-email-gerrit@erg.abdn.ac.uk\0" "From\0Arnaldo Carvalho de Melo <acme@redhat.com>\0" "Subject\0Re: [PATCH 03/37] dccp: List management for new feature negotiation\0" - "Date\0Thu, 28 Aug 2008 19:43:36 +0000\0" - "To\0dccp@vger.kernel.org\0" + "Date\0Thu, 28 Aug 2008 16:43:36 -0300\0" + "To\0Gerrit Renker <gerrit@erg.abdn.ac.uk>\0" + "Cc\0dccp@vger.kernel.org" + " netdev@vger.kernel.org\0" "\00:1\0" "b\0" "Em Thu, Aug 28, 2008 at 07:44:38PM +0200, Gerrit Renker escreveu:\n" @@ -50,7 +55,7 @@ "\n" "> +\t\tif (feat < entry->feat_num)\n" "> +\t\t\tbreak;\n" - "> +\t\tif (entry->feat_num = feat && entry->is_local = is_local) {\n" + "> +\t\tif (entry->feat_num == feat && entry->is_local == is_local) {\n" "> +\t\t\tdccp_feat_val_destructor(entry->feat_num, &entry->val);\n" "\n" "<first reaction>\n" @@ -88,7 +93,7 @@ "\n" "cool, here you use list_for_each_entry :-)\n" "\n" - "> +\t\tif (entry->feat_num = feat_num && entry->is_local = is_local)\n" + "> +\t\tif (entry->feat_num == feat_num && entry->is_local == is_local)\n" "> +\t\t\treturn entry;\n" "> +\t\telse if (entry->feat_num > feat_num)\n" "> +\t\t\tbreak;\n" @@ -113,7 +118,7 @@ "> +{\n" "> +\tstruct dccp_feat_entry *new = dccp_feat_entry_new(fn_list, feat, local);\n" "> +\n" - "> +\tif (new = NULL)\n" + "> +\tif (new == NULL)\n" "> +\t\treturn -ENOMEM;\n" "> +\n" "> +\tnew->feat_num\t = feat;\n" @@ -140,14 +145,14 @@ "> +{\n" "> +\tstruct dccp_feat_entry *new = dccp_feat_entry_new(fn_list, feat, local);\n" "> +\n" - "> +\tif (new = NULL)\n" + "> +\tif (new == NULL)\n" "> +\t\treturn DCCP_RESET_CODE_TOO_BUSY;\n" "> +\n" "> +\tnew->feat_num\t = feat;\n" "> +\tnew->is_local\t = local;\n" "> +\tnew->state\t = FEAT_STABLE;\t/* transition in 6.6.2 */\n" "> +\tnew->needs_confirm = 1;\n" - "> +\tnew->empty_confirm = (fval = NULL);\n" + "> +\tnew->empty_confirm = (fval == NULL);\n" "> +\tnew->val.nn\t = 0;\t\t/* zeroes the whole structure */\n" "> +\tif (!new->empty_confirm)\n" "> +\t\tnew->val = *fval;\n" @@ -184,4 +189,4 @@ "\n" - Arnaldo -282ea1c959b6fa095861b5b6d35c72b329c20fddd826b5ec2c93d1ae48f5c154 +ade464d2ad774ddf3b552369101cef774919146fc93d9fd75e39b84126eee654
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.