diff for duplicates of <20080828205447.GN9193@ghostprotocols.net> diff --git a/a/1.txt b/N1/1.txt index 418b50a..f355271 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -36,7 +36,7 @@ Em Thu, Aug 28, 2008 at 07:44:42PM +0200, Gerrit Renker escreveu: > + if (val > DCCPF_ACK_RATIO_MAX) > + val = DCCPF_ACK_RATIO_MAX; > -> if (val = dp->dccps_l_ack_ratio) +> if (val == dp->dccps_l_ack_ratio) > return; > --- a/net/dccp/feat.c > +++ b/net/dccp/feat.c @@ -60,7 +60,7 @@ Em Thu, Aug 28, 2008 at 07:44:42PM +0200, Gerrit Renker escreveu: > +{ > + switch (feat_num) { > + case DCCPF_CCID: -> + return val = DCCPC_CCID2 || val = DCCPC_CCID3; +> + return val == DCCPC_CCID2 || val == DCCPC_CCID3; Shouldn't we look at the registered CCIDs and do validation based on the modules loaded? Doing it this hardcoded way will prevent testing CCID4, @@ -84,7 +84,7 @@ multiple pluggable congestion control algorithms :-) > + > +static u8 dccp_feat_sp_list_ok(u8 feat_num, u8 const *sp_list, u8 sp_len) > +{ -> + if (sp_list = NULL || sp_len < 1) +> + if (sp_list == NULL || sp_len < 1) > + return 0; > + while (sp_len--) > + if (!dccp_feat_is_valid_sp_val(feat_num, *sp_list++)) @@ -110,7 +110,7 @@ multiple pluggable congestion control algorithms :-) > + return -EINVAL; > + > + /* Don't bother with default values, they will be activated anyway. */ -> + if (nn_val - (u64)dccp_feat_default_value(feat) = 0) +> + if (nn_val - (u64)dccp_feat_default_value(feat) == 0) > + return 0; > + > + return dccp_feat_push_change(fn, feat, 1, mandatory, &fval); @@ -208,7 +208,7 @@ multiple pluggable congestion control algorithms :-) > + */ > +/* Ack Ratio takes 2-byte integer values (11.3) */ > +#define DCCPF_ACK_RATIO_MAX 0xFFFF -> +/* Wmin2 and Wmax=2^46-1 from 7.5.2 */ +> +/* Wmin=32 and Wmax=2^46-1 from 7.5.2 */ > +#define DCCPF_SEQ_WMIN 32 > +#define DCCPF_SEQ_WMAX 0x3FFFFFFFFFFFull > + diff --git a/a/content_digest b/N1/content_digest index 5c943cb..e9b577c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,17 @@ + "ref\01219945512-7723-1-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-2-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-3-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-4-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-5-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-6-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-7-git-send-email-gerrit@erg.abdn.ac.uk\0" "ref\01219945512-7723-8-git-send-email-gerrit@erg.abdn.ac.uk\0" "From\0Arnaldo Carvalho de Melo <acme@redhat.com>\0" - "Subject\0Re: [PATCH 07/37] dccp: Registration routines for changing feature\0" - "Date\0Thu, 28 Aug 2008 20:54:47 +0000\0" - "To\0dccp@vger.kernel.org\0" + "Subject\0Re: [PATCH 07/37] dccp: Registration routines for changing feature values\0" + "Date\0Thu, 28 Aug 2008 17:54:47 -0300\0" + "To\0Gerrit Renker <gerrit@erg.abdn.ac.uk>\0" + "Cc\0dccp@vger.kernel.org" + " netdev@vger.kernel.org\0" "\00:1\0" "b\0" "Em Thu, Aug 28, 2008 at 07:44:42PM +0200, Gerrit Renker escreveu:\n" @@ -43,7 +52,7 @@ "> +\tif (val > DCCPF_ACK_RATIO_MAX)\n" "> +\t\tval = DCCPF_ACK_RATIO_MAX;\n" "> \n" - "> \tif (val = dp->dccps_l_ack_ratio)\n" + "> \tif (val == dp->dccps_l_ack_ratio)\n" "> \t\treturn;\n" "> --- a/net/dccp/feat.c\n" "> +++ b/net/dccp/feat.c\n" @@ -67,7 +76,7 @@ "> +{\n" "> +\tswitch (feat_num) {\n" "> +\tcase DCCPF_CCID:\n" - "> +\t\treturn val = DCCPC_CCID2 || val = DCCPC_CCID3;\n" + "> +\t\treturn val == DCCPC_CCID2 || val == DCCPC_CCID3;\n" "\n" "Shouldn't we look at the registered CCIDs and do validation based on the\n" "modules loaded? Doing it this hardcoded way will prevent testing CCID4,\n" @@ -91,7 +100,7 @@ "> +\n" "> +static u8 dccp_feat_sp_list_ok(u8 feat_num, u8 const *sp_list, u8 sp_len)\n" "> +{\n" - "> +\tif (sp_list = NULL || sp_len < 1)\n" + "> +\tif (sp_list == NULL || sp_len < 1)\n" "> +\t\treturn 0;\n" "> +\twhile (sp_len--)\n" "> +\t\tif (!dccp_feat_is_valid_sp_val(feat_num, *sp_list++))\n" @@ -117,7 +126,7 @@ "> +\t\treturn -EINVAL;\n" "> +\n" "> +\t/* Don't bother with default values, they will be activated anyway. */\n" - "> +\tif (nn_val - (u64)dccp_feat_default_value(feat) = 0)\n" + "> +\tif (nn_val - (u64)dccp_feat_default_value(feat) == 0)\n" "> +\t\treturn 0;\n" "> +\n" "> +\treturn dccp_feat_push_change(fn, feat, 1, mandatory, &fval);\n" @@ -215,7 +224,7 @@ "> + */\n" "> +/* Ack Ratio takes 2-byte integer values (11.3) */\n" "> +#define DCCPF_ACK_RATIO_MAX\t0xFFFF\n" - "> +/* Wmin2 and Wmax=2^46-1 from 7.5.2 */\n" + "> +/* Wmin=32 and Wmax=2^46-1 from 7.5.2 */\n" "> +#define DCCPF_SEQ_WMIN\t\t32\n" "> +#define DCCPF_SEQ_WMAX\t\t0x3FFFFFFFFFFFull\n" "> +\n" @@ -270,4 +279,4 @@ "> the body of a message to majordomo@vger.kernel.org\n" > More majordomo info at http://vger.kernel.org/majordomo-info.html -eb80d3b4b96f344443fc6e3a79ad6fb1b9f039093623c8c86d31c1976a7dbc5d +5ba6ffb977a3f4f41eb3e7c9d343c93c0bb49032d0f00dd8dcb09f6e56c09c5b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.