All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@sun.com>
To: Theodore Tso <tytso@mit.edu>
Cc: Ric Wheeler <rwheeler@redhat.com>,
	Eric Sandeen <sandeen@redhat.com>,
	ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: Do we need dump for ext4?
Date: Thu, 28 Aug 2008 16:23:48 -0600	[thread overview]
Message-ID: <20080828222348.GS3392@webber.adilger.int> (raw)
In-Reply-To: <20080828203553.GB10082@mit.edu>

On Aug 28, 2008  16:35 -0400, Theodore Ts'o wrote:
> Yeah, but that requires dealing with Ulrich and for my own mental
> health I try to avoid that as much as possible.  :-)
> 
> This idea is something that has been in my "if only I had time or some
> minions to dispatch" category for quite some time.  We can actually do
> this in the kernel.
> 
> For small directories which could potentially get converted into htree
> format, we already sucking the entire directory and putting it into an
> rbtree.  We could just do this for all directories less than or equal
> to 32k, but have them returned sorted by inode instead of by hash
> value.  At least on my laptop, this accounts for 99.93% of the
> directories on my root filesystem.

What happens if the directory is grown at that point?  I thought the
reason for keeping it sorted in hash order was to deal with the
telldir headache?  I guess if the whole thing is in memory then it
can be attached to the fd and discarded once read or seeked-on
(and POSIX doesn't require reporting new entries after the start
of the read).

Doing this at the VFS level would also benefit _most_ filesystems,
though maybe not ones like XFS or btrfs that have their own preferred
order.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.


  reply	other threads:[~2008-08-28 22:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-28 14:58 Do we need dump for ext4? Eric Sandeen
2008-08-28 18:48 ` Theodore Tso
2008-08-28 19:03   ` Ric Wheeler
2008-08-28 20:04     ` Andreas Dilger
2008-08-28 20:35       ` Theodore Tso
2008-08-28 22:23         ` Andreas Dilger [this message]
2008-08-28 22:34           ` Theodore Tso
2008-08-28 23:14             ` Andreas Dilger
2008-08-28 19:13   ` Eric Sandeen
2008-08-29 12:36 ` Eric Sandeen
2008-08-29 14:17   ` Theodore Tso
2008-08-29 18:14     ` Eric Sandeen
2008-08-31  2:43   ` Andreas Dilger
2008-09-02 15:52     ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080828222348.GS3392@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=rwheeler@redhat.com \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.