diff for duplicates of <20080829061237.GD3557@gerrit.erg.abdn.ac.uk> diff --git a/a/1.txt b/N1/1.txt index cef7752..d1eb15d 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,7 +3,7 @@ | > +{ | > + switch (feat_num) { | > + case DCCPF_CCID: -| > + return val = DCCPC_CCID2 || val = DCCPC_CCID3; +| > + return val == DCCPC_CCID2 || val == DCCPC_CCID3; | | Shouldn't we look at the registered CCIDs and do validation based on the | modules loaded? Doing it this hardcoded way will prevent testing CCID4, @@ -34,14 +34,14 @@ mechanism works as follows: if (ccid_get_builtin_ccids(&tx.val, &tx.len) || ccid_get_builtin_ccids(&rx.val, &rx.len)) return -ENOBUFS; - => If it succeeds, the `tx' and `rx' entries will be identical copies. + ==> If it succeeds, the `tx' and `rx' entries will be identical copies. 3. The next step in dccp_feat_init is to try and load all configured CCIDs: if (ccid_request_modules(tx.val, tx.len)) goto free_ccid_lists; - => If this succeeds, the host is ready to answer to any request by + ==> If this succeeds, the host is ready to answer to any request by the peer. 4. Finally, if the peer tries to negotiate an unknown CCID, negotiation diff --git a/a/content_digest b/N1/content_digest index 417a37b..4cd04ab 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,18 @@ + "ref\01219945512-7723-1-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-2-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-3-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-4-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-5-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-6-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\01219945512-7723-7-git-send-email-gerrit@erg.abdn.ac.uk\0" "ref\01219945512-7723-8-git-send-email-gerrit@erg.abdn.ac.uk\0" + "ref\020080828205447.GN9193@ghostprotocols.net\0" "From\0Gerrit Renker <gerrit@erg.abdn.ac.uk>\0" - "Subject\0Re: [PATCH 07/37] dccp: Registration routines for changing feature\0" - "Date\0Fri, 29 Aug 2008 06:12:37 +0000\0" - "To\0dccp@vger.kernel.org\0" + "Subject\0Re: [PATCH 07/37] dccp: Registration routines for changing feature values\0" + "Date\0Fri, 29 Aug 2008 08:12:37 +0200\0" + "To\0Arnaldo Carvalho de Melo <acme@redhat.com>" + dccp@vger.kernel.org + " netdev@vger.kernel.org\0" "\00:1\0" "b\0" "| > +/* check that SP values are within the ranges defined in RFC 4340 */\n" @@ -10,7 +20,7 @@ "| > +{\n" "| > +\tswitch (feat_num) {\n" "| > +\tcase DCCPF_CCID:\n" - "| > +\t\treturn val = DCCPC_CCID2 || val = DCCPC_CCID3;\n" + "| > +\t\treturn val == DCCPC_CCID2 || val == DCCPC_CCID3;\n" "| \n" "| Shouldn't we look at the registered CCIDs and do validation based on the\n" "| modules loaded? Doing it this hardcoded way will prevent testing CCID4,\n" @@ -41,14 +51,14 @@ " if (ccid_get_builtin_ccids(&tx.val, &tx.len) ||\n" " ccid_get_builtin_ccids(&rx.val, &rx.len))\n" " return -ENOBUFS;\n" - " => If it succeeds, the `tx' and `rx' entries will be identical copies.\n" + " ==> If it succeeds, the `tx' and `rx' entries will be identical copies.\n" "\n" " 3. The next step in dccp_feat_init is to try and load all configured CCIDs:\n" "\n" " if (ccid_request_modules(tx.val, tx.len))\n" " goto free_ccid_lists;\n" "\n" - " => If this succeeds, the host is ready to answer to any request by\n" + " ==> If this succeeds, the host is ready to answer to any request by\n" "\tthe peer.\n" "\n" " 4. Finally, if the peer tries to negotiate an unknown CCID, negotiation\n" @@ -56,4 +66,4 @@ " the peer has an entry in its CCID list which agrees with an entry of\n" our list. -4e3ae9efb763cacd5792b900bcf30c57df874914be7eec2e34ea2e1a089899c9 +0b9bfc0ace626b2ff4db81f21ce3e058623424e7d29e2c3040cd59a824cc1368
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.