From: David Brownell <david-b@pacbell.net>
To: linux-omap@vger.kernel.org
Subject: [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups
Date: Fri, 29 Aug 2008 10:12:47 -0700 [thread overview]
Message-ID: <200808291012.47332.david-b@pacbell.net> (raw)
From: David Brownell <dbrownell@users.sourceforge.net>
Clean up the Beagle NAND config a bit: use SZ_128K instead of
an arithmetic expression for the NAND block size. Set the
NAND_BUSWIDTH_16 flag. Make its init routine static.
(Unrelated: make omap3_beagle_i2c_init be part of beagle_init.
It shouldn't be called on non-beagle hardware; and beagle_init
already runs with other arch_initcall code.)
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
arch/arm/mach-omap2/board-omap3beagle.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
--- beagle.orig/arch/arm/mach-omap2/board-omap3beagle.c 2008-08-27 21:19:12.000000000 -0700
+++ beagle/arch/arm/mach-omap2/board-omap3beagle.c 2008-08-27 21:21:18.000000000 -0700
@@ -50,24 +50,24 @@ static struct mtd_partition omap3beagle_
{
.name = "X-Loader",
.offset = 0,
- .size = 4*(64 * 2048),
+ .size = 4 * SZ_128K,
.mask_flags = MTD_WRITEABLE, /* force read-only */
},
{
.name = "U-Boot",
.offset = MTDPART_OFS_APPEND, /* Offset = 0x80000 */
- .size = 15*(64 * 2048),
+ .size = 15 * SZ_128K,
.mask_flags = MTD_WRITEABLE, /* force read-only */
},
{
.name = "U-Boot Env",
.offset = MTDPART_OFS_APPEND, /* Offset = 0x260000 */
- .size = 1*(64 * 2048),
+ .size = 1 * SZ_128K,
},
{
.name = "Kernel",
.offset = MTDPART_OFS_APPEND, /* Offset = 0x280000 */
- .size = 32*(64 * 2048),
+ .size = 32 * SZ_128K,
},
{
.name = "File System",
@@ -77,6 +77,7 @@ static struct mtd_partition omap3beagle_
};
static struct omap_nand_platform_data omap3beagle_nand_data = {
+ .options = NAND_BUSWIDTH_16,
.parts = omap3beagle_nand_partitions,
.nr_parts = ARRAY_SIZE(omap3beagle_nand_partitions),
.dma_channel = -1, /* disable DMA in OMAP NAND driver */
@@ -205,7 +206,7 @@ static struct platform_device *omap3_bea
&keys_gpio,
};
-void __init omap3beagle_flash_init(void)
+static void __init omap3beagle_flash_init(void)
{
u8 cs = 0;
u8 nandcs = GPMC_CS_NUM + 1;
@@ -245,6 +246,7 @@ void __init omap3beagle_flash_init(void)
static void __init omap3_beagle_init(void)
{
+ omap3_beagle_i2c_init();
platform_add_devices(omap3_beagle_devices, ARRAY_SIZE(omap3_beagle_devices));
omap_board_config = omap3_beagle_config;
omap_board_config_size = ARRAY_SIZE(omap3_beagle_config);
@@ -255,8 +257,6 @@ static void __init omap3_beagle_init(voi
omap3beagle_flash_init();
}
-arch_initcall(omap3_beagle_i2c_init);
-
static void __init omap3_beagle_map_io(void)
{
omap2_set_globals_343x();
next reply other threads:[~2008-08-29 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 17:12 David Brownell [this message]
2008-08-29 23:56 ` [patch 2.6.27-rc3-omap1] omap3 beagle: nand (mostly) cleanups Woodruff, Richard
2008-08-30 4:23 ` David Brownell
2008-09-02 17:23 ` David Brownell
2008-09-02 17:31 ` Woodruff, Richard
2008-09-05 16:43 ` Tony Lindgren
2008-09-02 18:46 ` Steve Sakoman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808291012.47332.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.