All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Bordug <vitb@kernel.crashing.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: linux-usb@vger.kernel.org,
	"linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	Mark Miesfeld <mmiesfeld@amcc.com>, Stefan Roese <sr@denx.de>
Subject: Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata
Date: Fri, 29 Aug 2008 22:20:44 +0400	[thread overview]
Message-ID: <20080829222044.53c56bca@vitb-lp> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0808291121180.4447-100000@netrider.rowland.org>

В Fri, 29 Aug 2008 11:26:07 -0400 (EDT)
Alan Stern <stern@rowland.harvard.edu> пишет:

> On Fri, 29 Aug 2008, Benjamin Herrenschmidt wrote:
> 
> > I suppose some embedded platforms don't use CONFIG_PM, is this
> > still a requirement for autosuspend ? Or do that happen always on
> > an empty port nowadays ?
> 
> ohci-hcd doesn't automatically suspend the root hub if CONFIG_PM isn't
> set.  However it isn't necessary to set CONFIG_SLEEP,
> CONFIG_HIBERNATION, or CONFIG_USB_SUSPEND.

That is good to know. 

But even assuming PM set, common use-case of
embedded systems to have stuff on USB bus that is never plugged off;
and in case of compiled-in ehci and ohci there is just 

Initializing USB Mass Storage driver...
usb 1-1: new high speed USB device using ppc-of-ehci and address 2
usb 1-1: device descriptor read/all, error -110
hub 1-0:1.0: unable to enumerate USB device on port 1

(not touching PM here to be clear)

even 1-second delay would be enough for root hub to be hosed... So, is
the patch (with all the issues addressed) acceptable for mainline?

Thanks, 
-Vitaly

  reply	other threads:[~2008-08-29 18:21 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 22:23 [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errata Vitaly Bordug
2008-08-27 14:36 ` Alan Stern
2008-08-28 19:32   ` Vitaly Bordug
2008-08-28 20:13     ` Alan Stern
2008-08-28 21:11       ` Steven A. Falco
2008-08-28 21:33         ` Alan Stern
2008-08-28 22:43           ` Benjamin Herrenschmidt
2008-08-29 15:26             ` Alan Stern
2008-08-29 18:20               ` Vitaly Bordug [this message]
2008-08-29 21:30                 ` Alan Stern
2008-09-04 20:48                   ` Vitaly Bordug
2008-09-04 21:40                     ` Alan Stern
2008-09-05  1:35                       ` Benjamin Herrenschmidt
2008-09-05 13:01                       ` Vitaly Bordug
2008-09-05 15:17                         ` Alan Stern
2008-09-06  9:02                           ` Vitaly Bordug
2008-08-29 13:25           ` Steven A. Falco
2008-08-29 17:56         ` Matthias Fuchs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080829222044.53c56bca@vitb-lp \
    --to=vitb@kernel.crashing.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mmiesfeld@amcc.com \
    --cc=sr@denx.de \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.