From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZOzN-0005td-MX for mharc-grub-devel@gnu.org; Sat, 30 Aug 2008 07:51:33 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZOzL-0005rv-W2 for grub-devel@gnu.org; Sat, 30 Aug 2008 07:51:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZOzL-0005r2-EC for grub-devel@gnu.org; Sat, 30 Aug 2008 07:51:31 -0400 Received: from [199.232.76.173] (port=60132 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZOzL-0005qj-3O for grub-devel@gnu.org; Sat, 30 Aug 2008 07:51:31 -0400 Received: from aybabtu.com ([69.60.117.155]:46958) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KZOzK-0005jy-NK for grub-devel@gnu.org; Sat, 30 Aug 2008 07:51:30 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KZOpU-0006sE-Nr for grub-devel@gnu.org; Sat, 30 Aug 2008 13:41:21 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KZOxx-0001GZ-5q for grub-devel@gnu.org; Sat, 30 Aug 2008 13:50:05 +0200 Date: Sat, 30 Aug 2008 13:50:05 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080830115005.GE16775@thorin> References: <20080824130216.GA5808@pina.cat> <20080824142944.GA9470@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080824142944.GA9470@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Aug 2008 11:51:32 -0000 On Sun, Aug 24, 2008 at 04:29:44PM +0200, Carles Pina i Estany wrote: > > Hi, > > I was just thinking now... > > On Aug/24/2008, Carles Pina i Estany wrote: > > > * include/grub/powerpc/ieee1275/console.h (GRUB_TERM_NPAGE): > > Changed to 0x5100. > > (GRUB_TERM_PPAGE): Changed to 0x4900. > > > > * include/grub/sparc64/ieee1275/console.h: Likewise. > > > > * include/grub/i386/pc/console.h: Likewise. > > > > * include/grub/efi/console.h: Likewise. > > I was just thinking... is there any reason that we have the same macros > in 4 different files? This would need to be checked carefully, but a quick peek at GRUB_CONSOLE_KEY_LEFT: ./kern/i386/pc/startup.S: .word GRUB_CONSOLE_KEY_LEFT, GRUB_TERM_LEFT ./include/grub/i386/pc/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00 ./include/grub/efi/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00 ./include/grub/powerpc/ieee1275/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00 ./include/grub/sparc64/ieee1275/console.h:#define GRUB_CONSOLE_KEY_LEFT 0x4B00 seems to indicate these macros are part of the BIOS console interface, and therefore only used on i386-pc. If you can confirm this, I'd recommend just removing them from the other console.h files. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."